[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143796#comment-13143796
]
Robert Muir commented on LUCENE-3490:
-
thanks selckin, the problem is that patch is a
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143797#comment-13143797
]
selckin commented on LUCENE-3490:
-
yeah i turned on really aggressive rename detection,
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143805#comment-13143805
]
Robert Muir commented on LUCENE-3490:
-
ahh thanks... but this patch is 'reversed'
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143810#comment-13143810
]
Robert Muir commented on LUCENE-3490:
-
ok this one is pretty good for review, thanks!
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143922#comment-13143922
]
Uwe Schindler commented on LUCENE-3490:
---
+1 I see no merge problems, so no
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143926#comment-13143926
]
Robert Muir commented on LUCENE-3490:
-
Thanks for the policework Uwe... I think I
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143375#comment-13143375
]
Robert Muir commented on LUCENE-3490:
-
All the nocommits have been cleared up, the
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143402#comment-13143402
]
Andrzej Bialecki commented on LUCENE-3490:
---
Awesome work, guys! +1 to merging
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143422#comment-13143422
]
Uwe Schindler commented on LUCENE-3490:
---
+1 to merge back, maybe as always create a
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143423#comment-13143423
]
Robert Muir commented on LUCENE-3490:
-
I'll create a diff. it will look ugly though,
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143427#comment-13143427
]
Uwe Schindler commented on LUCENE-3490:
---
I have Svn 1.7.1, there its much better.
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143429#comment-13143429
]
Robert Muir commented on LUCENE-3490:
-
{quote}
I have Svn 1.7.1, there its much
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143441#comment-13143441
]
Uwe Schindler commented on LUCENE-3490:
---
I'll merge and try, give me some time...
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143463#comment-13143463
]
Uwe Schindler commented on LUCENE-3490:
---
Does not look better. It puts all moves
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141001#comment-13141001
]
Uwe Schindler commented on LUCENE-3490:
---
bq. remains to factor out all these little
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1314#comment-1314
]
Uwe Schindler commented on LUCENE-3490:
---
I removed CodecProvider again in revision:
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140737#comment-13140737
]
Uwe Schindler commented on LUCENE-3490:
---
Committed lucene2621-branch revision
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140810#comment-13140810
]
Uwe Schindler commented on LUCENE-3490:
---
Just some comments:
The current impl is
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140858#comment-13140858
]
Robert Muir commented on LUCENE-3490:
-
{quote}
If we decide for Codecs, that the part
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140897#comment-13140897
]
Robert Muir commented on LUCENE-3490:
-
{quote}
Robert: It's your turn now for
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139662#comment-13139662
]
Uwe Schindler commented on LUCENE-3490:
---
A good example how this could work is
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139665#comment-13139665
]
Robert Muir commented on LUCENE-3490:
-
Thanks Uwe, I think once we get tests passing
[
https://issues.apache.org/jira/browse/LUCENE-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139694#comment-13139694
]
Uwe Schindler commented on LUCENE-3490:
---
We should make the API like for Charsets,
23 matches
Mail list logo
