[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449931#comment-13449931
]
Michael McCandless commented on LUCENE-4123:
bq. I am not sure if we really
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448829#comment-13448829
]
Shai Erera commented on LUCENE-4123:
Besides Uwe's ideas for improvements, is this
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448842#comment-13448842
]
Michael McCandless commented on LUCENE-4123:
I believe it is safe ... eg all
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448870#comment-13448870
]
Robert Muir commented on LUCENE-4123:
-
looks good... i dont really like that close()
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448884#comment-13448884
]
Robert Muir commented on LUCENE-4123:
-
also readBytes should not catch
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449225#comment-13449225
]
Uwe Schindler commented on LUCENE-4123:
---
Mike,
I am not sure if we really need that
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404743#comment-13404743
]
Michael McCandless commented on LUCENE-4123:
bq. You should make the II
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404742#comment-13404742
]
Michael McCandless commented on LUCENE-4123:
bq. You should make the II
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404747#comment-13404747
]
Uwe Schindler commented on LUCENE-4123:
---
bq. Are we sure the catch + rethrow adds
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404856#comment-13404856
]
Michael McCandless commented on LUCENE-4123:
OK thanks Uwe!
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404429#comment-13404429
]
Uwe Schindler commented on LUCENE-4123:
---
You should make the II correctly throw
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404452#comment-13404452
]
Uwe Schindler commented on LUCENE-4123:
---
When thinking more about the patch:
Can we
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291857#comment-13291857
]
Simon Willnauer commented on LUCENE-4123:
-
bq.I tested with 1M Wikipedia english
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291860#comment-13291860
]
Robert Muir commented on LUCENE-4123:
-
I dont think it buys anything to code dup the
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291884#comment-13291884
]
Michael McCandless commented on LUCENE-4123:
Results for 5M doc index:
[
https://issues.apache.org/jira/browse/LUCENE-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291886#comment-13291886
]
Michael McCandless commented on LUCENE-4123:
bq. I dont think it buys
16 matches
Mail list logo