[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424592#comment-13424592
]
Michael McCandless commented on LUCENE-4190:
I think for now we should just
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409739#comment-13409739
]
Michael McCandless commented on LUCENE-4190:
bq. I think that the way to
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407858#comment-13407858
]
Andi Vajda commented on LUCENE-4190:
{quote}
1. subdirectories currently are a
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407862#comment-13407862
]
Robert Muir commented on LUCENE-4190:
-
{quote}
As for backwards compatibility, one
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406874#comment-13406874
]
Shai Erera commented on LUCENE-4190:
What if we had an object called IndexFileNames
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406877#comment-13406877
]
Gilad Barkai commented on LUCENE-4190:
--
Perhaps out of context, but here goes..
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406879#comment-13406879
]
selckin commented on LUCENE-4190:
-
what if you accidentally call deleteAll() on your
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406951#comment-13406951
]
Robert Muir commented on LUCENE-4190:
-
Again: I am totally against complicated file
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407001#comment-13407001
]
Carl Austin commented on LUCENE-4190:
-
I was the original commenter on the blog about
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407027#comment-13407027
]
Shai Erera commented on LUCENE-4190:
bq. We HAVE to keep this kind of code simple and
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407033#comment-13407033
]
Michael McCandless commented on LUCENE-4190:
I agree there is a real danger
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407034#comment-13407034
]
Robert Muir commented on LUCENE-4190:
-
The problem with a global filter is that what
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407040#comment-13407040
]
Robert Muir commented on LUCENE-4190:
-
{quote}
Since a general codec must already
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407086#comment-13407086
]
Gilad Barkai commented on LUCENE-4190:
--
{quote}
So if we insist on a perfect
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407088#comment-13407088
]
Yonik Seeley commented on LUCENE-4190:
--
Robert, you completely ignored my explicit
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407091#comment-13407091
]
Robert Muir commented on LUCENE-4190:
-
you can't veto me backing out my own commit.
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407094#comment-13407094
]
Mark Miller commented on LUCENE-4190:
-
bq. pretty sure I have the right to revert my
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407099#comment-13407099
]
Mark Harwood commented on LUCENE-4190:
--
-1 for merrily wiping contents of whatever
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407097#comment-13407097
]
Robert Muir commented on LUCENE-4190:
-
Thats ok, its clearly another typical
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407104#comment-13407104
]
Mark Miller commented on LUCENE-4190:
-
bq. Thats ok, its clearly another typical
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407107#comment-13407107
]
Robert Muir commented on LUCENE-4190:
-
I think if you read through the issue, how is
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407115#comment-13407115
]
Mark Miller commented on LUCENE-4190:
-
{quote}Another way to look at it: I committed
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407145#comment-13407145
]
Robert Muir commented on LUCENE-4190:
-
{quote}
The words, the threat, the quick
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407148#comment-13407148
]
Yonik Seeley commented on LUCENE-4190:
--
bq. But I think this was premature, because
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407151#comment-13407151
]
Robert Muir commented on LUCENE-4190:
-
{quote}
I didn't see anyone saying that
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407157#comment-13407157
]
Uwe Schindler commented on LUCENE-4190:
---
Hi,
I was thinking about the whole thing
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407155#comment-13407155
]
Robert Muir commented on LUCENE-4190:
-
{quote}
So if there are no objections, I'll
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407162#comment-13407162
]
Robert Muir commented on LUCENE-4190:
-
{quote}
I was thinking about the whole thing
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407167#comment-13407167
]
Robert Muir commented on LUCENE-4190:
-
just to mention: the reason I don't like the
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407170#comment-13407170
]
Uwe Schindler commented on LUCENE-4190:
---
{quote}
bq. Assert makes no sense here as
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407177#comment-13407177
]
Robert Muir commented on LUCENE-4190:
-
I'm not 1000% determined for it to only be an
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407181#comment-13407181
]
Uwe Schindler commented on LUCENE-4190:
---
String.startsWith(_) static string is
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407185#comment-13407185
]
Robert Muir commented on LUCENE-4190:
-
Uwe, no i mean that we check the entire list
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407196#comment-13407196
]
Uwe Schindler commented on LUCENE-4190:
---
New patch looks good, I was not aware that
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407365#comment-13407365
]
Robert Muir commented on LUCENE-4190:
-
{quote}
I think that the way to bound the
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407550#comment-13407550
]
Michael McCandless commented on LUCENE-4190:
I think
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407562#comment-13407562
]
Robert Muir commented on LUCENE-4190:
-
I think the regex matching the current
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406497#comment-13406497
]
Michael McCandless commented on LUCENE-4190:
History repeats itself:
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406500#comment-13406500
]
Robert Muir commented on LUCENE-4190:
-
I dont think we should do anything beyond
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406510#comment-13406510
]
Shai Erera commented on LUCENE-4190:
I also raised an eyebrow when I read this
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406517#comment-13406517
]
Robert Muir commented on LUCENE-4190:
-
We track the files, but what if your computer
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406519#comment-13406519
]
Robert Muir commented on LUCENE-4190:
-
patch is against branch_4x
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406520#comment-13406520
]
Michael McCandless commented on LUCENE-4190:
bq. Many of the lucene+facet
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406521#comment-13406521
]
Andi Vajda commented on LUCENE-4190:
I think that the way to bound the namespace of
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406525#comment-13406525
]
Shai Erera commented on LUCENE-4190:
Let's keep it simple, I agree.
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406529#comment-13406529
]
Robert Muir commented on LUCENE-4190:
-
We can maybe improve in the future besides the
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406541#comment-13406541
]
Uwe Schindler commented on LUCENE-4190:
---
Robert: assertSaneFiles is called
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406542#comment-13406542
]
Robert Muir commented on LUCENE-4190:
-
nice catch, thanks for reviewing Uwe!
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406613#comment-13406613
]
Michael McCandless commented on LUCENE-4190:
Patch looks good!
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406640#comment-13406640
]
Hoss Man commented on LUCENE-4190:
--
bq. I think that the way to bound the namespace of
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406642#comment-13406642
]
Robert Muir commented on LUCENE-4190:
-
{quote}
One sanity check: this may be an
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406644#comment-13406644
]
Yonik Seeley commented on LUCENE-4190:
--
bq. isn't that in theory already the point
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406646#comment-13406646
]
Robert Muir commented on LUCENE-4190:
-
Then its probably a good time to put those
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406648#comment-13406648
]
Yonik Seeley commented on LUCENE-4190:
--
How about we keep it simple and practical
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406652#comment-13406652
]
Robert Muir commented on LUCENE-4190:
-
I'm not trying to be pedantic: I don't want
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406669#comment-13406669
]
Andi Vajda commented on LUCENE-4190:
If Joe user gives c:\ as their index directory,
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406671#comment-13406671
]
Robert Muir commented on LUCENE-4190:
-
now I'm ready to be pedantic: I refuse to let
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406682#comment-13406682
]
Yonik Seeley commented on LUCENE-4190:
--
bq. Thats why i took this issue (and already
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406784#comment-13406784
]
Robert Muir commented on LUCENE-4190:
-
I still plan to revert tomorrow. I think the
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406786#comment-13406786
]
Yonik Seeley commented on LUCENE-4190:
--
bq. I still plan to revert tomorrow.
-1
[
https://issues.apache.org/jira/browse/LUCENE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406789#comment-13406789
]
Robert Muir commented on LUCENE-4190:
-
pretty sure I have the right to revert my own
61 matches
Mail list logo
