[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2013-03-22 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610744#comment-13610744 ] Commit Tag Bot commented on LUCENE-4425: [branch_4x commit] Robert Muir

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2013-03-22 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610752#comment-13610752 ] Commit Tag Bot commented on LUCENE-4425: [branch_4x commit] Robert Muir

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462692#comment-13462692 ] Robert Muir commented on LUCENE-4425: - Currently the responsibility is on the codecs

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462696#comment-13462696 ] Robert Muir commented on LUCENE-4425: - I would support removing offset and length

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462699#comment-13462699 ] Adrien Grand commented on LUCENE-4425: -- bq. I would support removing offset and

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462702#comment-13462702 ] Robert Muir commented on LUCENE-4425: - If we change this API, one way is to do it

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462710#comment-13462710 ] Adrien Grand commented on LUCENE-4425: -- bq. However StoredFieldsVisitor is an

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462713#comment-13462713 ] Robert Muir commented on LUCENE-4425: - I agree Adrien. I guess i immediately jumped

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462727#comment-13462727 ] Adrien Grand commented on LUCENE-4425: -- bq. commit LUCENE-4423 and get the bug fixed

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462859#comment-13462859 ] Michael McCandless commented on LUCENE-4425: +1 to remove offset/length and

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462862#comment-13462862 ] Michael McCandless commented on LUCENE-4425: Maybe we should fix this for

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463041#comment-13463041 ] Adrien Grand commented on LUCENE-4425: -- bq. Maybe we should fix this for 4.0? It

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463145#comment-13463145 ] Michael McCandless commented on LUCENE-4425: +1 Unclear

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463201#comment-13463201 ] Adrien Grand commented on LUCENE-4425: -- +1 too Unclear

[jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue

2012-09-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463475#comment-13463475 ] Robert Muir commented on LUCENE-4425: - I do think we should fix the API bug for 4.0,