[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610735#comment-13610735
]
Commit Tag Bot commented on LUCENE-4440:
[branch_4x commit] Uwe Schindler
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464715#comment-13464715
]
Shai Erera commented on LUCENE-4440:
if possible, I'd like to commit it to 4.0 too,
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464721#comment-13464721
]
Robert Muir commented on LUCENE-4440:
-
This is also similar to what i suggested on
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464722#comment-13464722
]
Adrien Grand commented on LUCENE-4440:
--
bq. If we do this, we should probably add a
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464724#comment-13464724
]
Adrien Grand commented on LUCENE-4440:
--
Maybe we should also test {{loader}} against
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464727#comment-13464727
]
Shai Erera commented on LUCENE-4440:
I can add to Codec.forName() something like
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464728#comment-13464728
]
Uwe Schindler commented on LUCENE-4440:
---
This is the same chicken-and-egg problem
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464729#comment-13464729
]
Robert Muir commented on LUCENE-4440:
-
From the documentation perspective, the
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464731#comment-13464731
]
Shai Erera commented on LUCENE-4440:
And separately, i.e. separate issue, not for
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464736#comment-13464736
]
Robert Muir commented on LUCENE-4440:
-
I would prefer something like this patch over
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464737#comment-13464737
]
Shai Erera commented on LUCENE-4440:
bq. I agree we should add a null check in
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464738#comment-13464738
]
Uwe Schindler commented on LUCENE-4440:
---
bq. Maybe we should also test loader
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464740#comment-13464740
]
Uwe Schindler commented on LUCENE-4440:
---
Ah you are right, it might be == null.
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464750#comment-13464750
]
Uwe Schindler commented on LUCENE-4440:
---
Inside NamedSPILoader loader all is fine,
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464753#comment-13464753
]
Shai Erera commented on LUCENE-4440:
Isn't there a way to ensure that NamedSPILoader
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464770#comment-13464770
]
Uwe Schindler commented on LUCENE-4440:
---
Please add this also to listCodecs maybe
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464778#comment-13464778
]
Uwe Schindler commented on LUCENE-4440:
---
bq. Isn't there a way to ensure that
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464909#comment-13464909
]
Robert Muir commented on LUCENE-4440:
-
thanks for adding these checks: I think this
[
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465040#comment-13465040
]
Shai Erera commented on LUCENE-4440:
Thanks Uwe for adding the messages and
19 matches
Mail list logo
