[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2013-03-22 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610657#comment-13610657 ] Commit Tag Bot commented on LUCENE-4479: [branch_4x commit] Alan Woodward http://

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477990#comment-13477990 ] Robert Muir commented on LUCENE-4479: - with the current patch, 'ant precommit' fails:

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475171#comment-13475171 ] Robert Muir commented on LUCENE-4479: - you're right: thanks! > Token

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475155#comment-13475155 ] Alan Woodward commented on LUCENE-4479: --- TokenSourcesTest.testOverlapWithOffset() t

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475148#comment-13475148 ] Robert Muir commented on LUCENE-4479: - Alan this patch looks good. Thanks for tacklin

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475055#comment-13475055 ] Alan Woodward commented on LUCENE-4479: --- It looks as though these classes are only

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475045#comment-13475045 ] Robert Muir commented on LUCENE-4479: - I'm not sure whats going on here :) If you can

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475043#comment-13475043 ] Alan Woodward commented on LUCENE-4479: --- So this snippet: if (!tokenPositionsG

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475041#comment-13475041 ] Alan Woodward commented on LUCENE-4479: --- Ah, but TokenStreamFromTermPositionVector

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475039#comment-13475039 ] Robert Muir commented on LUCENE-4479: - but the behavior of throwing IAE is still bogu

[jira] [Commented] (LUCENE-4479) TokenSources.getTokenStream() doesn't return correctly for termvectors with positions but no offsets

2012-10-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475037#comment-13475037 ] Robert Muir commented on LUCENE-4479: - {quote} However, if the Terms instance passed