[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507355#comment-13507355 ] Robert Muir commented on LUCENE-4574: - one thing that made it hard for me to review:

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507476#comment-13507476 ] David Smiley commented on LUCENE-4574: -- Indeed this is complicated. It's par for

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507499#comment-13507499 ] Robert Muir commented on LUCENE-4574: - {quote} So why do you hate this very simple

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507500#comment-13507500 ] Michael McCandless commented on LUCENE-4574: I love those asserts :) I think

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507045#comment-13507045 ] Robert Muir commented on LUCENE-4574: - Just to bold what I said before, as I feel its

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505528#comment-13505528 ] David Smiley commented on LUCENE-4574: -- But Robert, if I simply change the scenario

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505548#comment-13505548 ] Robert Muir commented on LUCENE-4574: - Right, there is more fixing needed for the

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505582#comment-13505582 ] David Smiley commented on LUCENE-4574: -- I don't have any conviction on what the

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505619#comment-13505619 ] Robert Muir commented on LUCENE-4574: - I think its generally cheap. like today its

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505650#comment-13505650 ] David Smiley commented on LUCENE-4574: -- Rob, FunctionQuery$AllScorer.score() is

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505676#comment-13505676 ] Adrien Grand commented on LUCENE-4574: -- bq. Add a ValueSource method boolean

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505034#comment-13505034 ] Robert Muir commented on LUCENE-4574: - I don't think we should do this. If you are

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505041#comment-13505041 ] David Smiley commented on LUCENE-4574: -- Ok, then SolrIndexSearcher.getDocListNC()

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505044#comment-13505044 ] Robert Muir commented on LUCENE-4574: - Yes: thats the correct fix... already

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-25 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503497#comment-13503497 ] Yonik Seeley commented on LUCENE-4574: -- FunctionValues isn't the right place to

[jira] [Commented] (LUCENE-4574) FunctionQuery ValueSource value computed twice per document

2012-11-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503533#comment-13503533 ] David Smiley commented on LUCENE-4574: -- To answer your question, Yonik, sort is to