[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-20 Thread Renaud Delbru (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607809#comment-13607809 ] Renaud Delbru commented on LUCENE-4642: --- Thanks for committing this, Steve and Robe

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-14 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603161#comment-13603161 ] Commit Tag Bot commented on LUCENE-4642: [branch_4x commit] Steven Rowe http://sv

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603129#comment-13603129 ] Robert Muir commented on LUCENE-4642: - Thanks a lot.. this is very nice IMO.

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-14 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603127#comment-13603127 ] Commit Tag Bot commented on LUCENE-4642: [trunk commit] Steven Rowe http://svn.ap

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603025#comment-13603025 ] Robert Muir commented on LUCENE-4642: - {quote} In this patch there is a new even more

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-14 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602482#comment-13602482 ] Steve Rowe commented on LUCENE-4642: {quote} and in the base tokenizerfactory have {c

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601118#comment-13601118 ] Commit Tag Bot commented on LUCENE-4642: [trunk commit] Steven Rowe http://svn.ap

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601108#comment-13601108 ] Commit Tag Bot commented on LUCENE-4642: [branch_4x commit] Steven Rowe http://sv

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600801#comment-13600801 ] Robert Muir commented on LUCENE-4642: - Its not a constructor explosion argument, beca

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-12 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600793#comment-13600793 ] Steve Rowe commented on LUCENE-4642: Somewhere else? You mean, everywhere it's used?

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600679#comment-13600679 ] Robert Muir commented on LUCENE-4642: - I think the way forward is to have one create(

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-12 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600573#comment-13600573 ] Steve Rowe commented on LUCENE-4642: I haven't resolved this issue because of Robert'

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-12 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600564#comment-13600564 ] Steve Rowe commented on LUCENE-4642: Thanks Renaud for being persistent :)

[jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

2013-03-12 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600562#comment-13600562 ] Steve Rowe commented on LUCENE-4642: Committed to trunk r1455670 and branch_4x r14556