[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618261#comment-13618261
]
Shai Erera commented on LUCENE-4893:
I chose not to throw an exception because
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618308#comment-13618308
]
crocket commented on LUCENE-4893:
-
LUCENE-4893.patch has some typos in comments.
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618319#comment-13618319
]
Michael McCandless commented on LUCENE-4893:
bq. I chose not to throw an
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618324#comment-13618324
]
Shai Erera commented on LUCENE-4893:
That would mean FacetsCollector will need to
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618413#comment-13618413
]
Michael McCandless commented on LUCENE-4893:
I think caching the result (so
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618474#comment-13618474
]
Michael McCandless commented on LUCENE-4893:
+1, thanks Shai!
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618147#comment-13618147
]
crocket commented on LUCENE-4893:
-
I assumed FacetsCollector.getFacetResults was a simple
[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618234#comment-13618234
]
Shai Erera commented on LUCENE-4893:
I didn't want to make FacetsCollector remember