[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013418#comment-14013418 ] Michael McCandless commented on LUCENE-5645: Maybe we could simply use

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013428#comment-14013428 ] Robert Muir commented on LUCENE-5645: - I'm still confused: since when was the empty

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-30 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013429#comment-14013429 ] Dawid Weiss commented on LUCENE-5645: - Why is randomized testing lenient? It parses

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-30 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013433#comment-14013433 ] Dawid Weiss commented on LUCENE-5645: - I'm still confused: since when was the empty

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013441#comment-14013441 ] Robert Muir commented on LUCENE-5645: - {quote} It's been supported since the very

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-30 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013452#comment-14013452 ] Dawid Weiss commented on LUCENE-5645: - I'll keep the previous behaviour in

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991570#comment-13991570 ] David Smiley commented on LUCENE-5645: -- In case you have more to add, I'll commit

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990224#comment-13990224 ] David Smiley commented on LUCENE-5645: -- The change is obviously trivial; I won't

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-05 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990244#comment-13990244 ] Robert Muir commented on LUCENE-5645: - Wait, please take a step back before rushing

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990256#comment-13990256 ] David Smiley commented on LUCENE-5645: -- I wonder the same; I'll try and see why.

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-05 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990267#comment-13990267 ] Robert Muir commented on LUCENE-5645: - I'm not sure. If tests.seed is empty, then

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990282#comment-13990282 ] David Smiley commented on LUCENE-5645: -- So it turns out this has to do with

[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of tests.seed system property

2014-05-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990301#comment-13990301 ] David Smiley commented on LUCENE-5645: -- IntelliJ bug report: