[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-10-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939628#comment-14939628 ] Alan Woodward commented on LUCENE-6785: --- The API isn't as tidy, but I think you're right that this

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907871#comment-14907871 ] Adrien Grand commented on LUCENE-6785: -- Sorry for the late reply, I was on vacation and just

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-15 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745750#comment-14745750 ] Alan Woodward commented on LUCENE-6785: --- [~jpountz] are you happy with the latest patch? Or do you

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-13 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742575#comment-14742575 ] Robert Muir commented on LUCENE-6785: - What is the reason to add such complexity? > Consider merging

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742579#comment-14742579 ] Alan Woodward commented on LUCENE-6785: --- Do you mean the getCacheKey() method? It decouples query

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738913#comment-14738913 ] Alan Woodward commented on LUCENE-6785: --- I'm travelling at the moment, will put up a larger patch

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739701#comment-14739701 ] Adrien Grand commented on LUCENE-6785: -- bq. The bits keeping the QueryCache happy are a bit hacky,

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736431#comment-14736431 ] Adrien Grand commented on LUCENE-6785: -- I think the API is more usable this way. The only concern I

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-09 Thread Terry Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736932#comment-14736932 ] Terry Smith commented on LUCENE-6785: - The original patch drops a few key settings from the

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735655#comment-14735655 ] Robert Muir commented on LUCENE-6785: - I didn't thoroughly examine the patch, but this part alone is

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735064#comment-14735064 ] Adrien Grand commented on LUCENE-6785: -- +1 to fold rewrite into createWeight For the record I tried

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-09-08 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735088#comment-14735088 ] David Smiley commented on LUCENE-6785: -- It'll be interesting to see how it all looks in the patch.