[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-09-10 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609536#comment-16609536 ] Michael McCandless commented on LUCENE-7882: Thanks for the explanation [~hypothesisx86];

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-31 Thread Tony Xu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599076#comment-16599076 ] Tony Xu commented on LUCENE-7882: - Oh I forgot to paste the test output.   2 Loading class , using

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-31 Thread Tony Xu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599071#comment-16599071 ] Tony Xu commented on LUCENE-7882: - To explain why Mike saw a many threads getting blocked on a monitor.

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599043#comment-16599043 ] Robert Muir commented on LUCENE-7882: - Well I think it needs to be tested on a modern JVM (e.g.

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599040#comment-16599040 ] Uwe Schindler commented on LUCENE-7882: --- IMHO, caching the compiled expressions is not Lucene's

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599031#comment-16599031 ] Michael McCandless commented on LUCENE-7882: But even once the JVM fixes its bugs and we can

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597774#comment-16597774 ] Robert Muir commented on LUCENE-7882: - I really still think we shouldn't add any java-level caches

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-30 Thread Tony Xu (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597756#comment-16597756 ] Tony Xu commented on LUCENE-7882: - A simple idea here can be caching the compiled Expression instances.

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-07-05 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074552#comment-16074552 ] Dawid Weiss commented on LUCENE-7882: - As far as I understand it should sweep code cache from time to

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-07-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074536#comment-16074536 ] Michael McCandless commented on LUCENE-7882: Sorry, I did not experience a full

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-07-05 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074399#comment-16074399 ] Dawid Weiss commented on LUCENE-7882: - Here is a bit more in-depth info.

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-07-05 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074396#comment-16074396 ] Dawid Weiss commented on LUCENE-7882: - Code cache is an area I don't have much experience with. It's

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-07-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074108#comment-16074108 ] Michael McCandless commented on LUCENE-7882: I ran my searcher instance with

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-06-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057319#comment-16057319 ] Dawid Weiss commented on LUCENE-7882: - These one-off class loaders should be gc-ed if there are no

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-06-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056605#comment-16056605 ] Robert Muir commented on LUCENE-7882: - I know i have benchmarked that its definitely slower not to

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-06-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056533#comment-16056533 ] Michael McCandless commented on LUCENE-7882: That's a great question [~dawid.weiss]; I don't

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2017-06-19 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053984#comment-16053984 ] Dawid Weiss commented on LUCENE-7882: - It probably does because they're loaded into their own class