[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087429#comment-16087429 ] ASF subversion and git services commented on LUCENE-7905: - Commit

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087430#comment-16087430 ] ASF subversion and git services commented on LUCENE-7905: - Commit

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-13 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085535#comment-16085535 ] Robert Muir commented on LUCENE-7905: - thanks Mike! > Optimizations for OrdinalMap >

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-13 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085452#comment-16085452 ] Dawid Weiss commented on LUCENE-7905: - It'd probably have to be stored per-leaf of a binary tree the

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085437#comment-16085437 ] Michael McCandless commented on LUCENE-7905: bq. You could do it with radix-like sort, but

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-13 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085423#comment-16085423 ] Dawid Weiss commented on LUCENE-7905: - bq. I do feel like how we compare terms in the PQ is

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085413#comment-16085413 ] Michael McCandless commented on LUCENE-7905: Good point @rcmuir; I'll improve the javadocs.

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085139#comment-16085139 ] Robert Muir commented on LUCENE-7905: - I think its good to pull out OrdinalMap into its own class

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084349#comment-16084349 ] Robert Muir commented on LUCENE-7905: - {quote} That's it, except I also changed: while

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084281#comment-16084281 ] Michael McCandless commented on LUCENE-7905: bq. Its a bit tricky to see the diffs since the

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084284#comment-16084284 ] Michael McCandless commented on LUCENE-7905: bq. Maybe we should also check how much better

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084134#comment-16084134 ] Adrien Grand commented on LUCENE-7905: -- I like the idea of switching to a simple priority queue to

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084128#comment-16084128 ] Robert Muir commented on LUCENE-7905: - Its a bit tricky to see the diffs since the file got moved

[jira] [Commented] (LUCENE-7905) Optimizations for OrdinalMap

2017-07-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084136#comment-16084136 ] Robert Muir commented on LUCENE-7905: - >From your explain that MTE must do more work because it