[jira] [Commented] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327779#comment-16327779 ] ASF subversion and git services commented on LUCENE-8129: - Commit

[jira] [Commented] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327770#comment-16327770 ] ASF subversion and git services commented on LUCENE-8129: - Commit

[jira] [Commented] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324246#comment-16324246 ] Robert Muir commented on LUCENE-8129: - otherwise patch looks great to me. thanks! > Support for

[jira] [Commented] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324172#comment-16324172 ] Robert Muir commented on LUCENE-8129: - Minor nitpick: can we rename it from {{normalizer}} to

[jira] [Commented] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323940#comment-16323940 ] Robert Muir commented on LUCENE-8129: - Need to double-check, but i'm pretty sure these things are

[jira] [Commented] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323919#comment-16323919 ] Robert Muir commented on LUCENE-8129: - Thanks for the patch. I don't like the change to the way the