[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510773#comment-16510773
]
ASF subversion and git services commented on LUCENE-8165:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510771#comment-16510771
]
ASF subversion and git services commented on LUCENE-8165:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504656#comment-16504656
]
Nhat Nguyen commented on LUCENE-8165:
-
[~rcmuir] I will look at LUCENE-8164 and post the output.
>
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504650#comment-16504650
]
Robert Muir commented on LUCENE-8165:
-
I think these commits may also fix LUCENE-8164 too: I haven't
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504647#comment-16504647
]
Adrien Grand commented on LUCENE-8165:
--
You're welcome. I was also wondering about unexpected side
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504639#comment-16504639
]
Robert Muir commented on LUCENE-8165:
-
Thanks Adrien: (also for branching first!). I'm sorry I was
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504595#comment-16504595
]
Nhat Nguyen commented on LUCENE-8165:
-
Thanks everyone!
> ban Arrays.copyOfRange with forbidden
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504442#comment-16504442
]
ASF subversion and git services commented on LUCENE-8165:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504387#comment-16504387
]
ASF subversion and git services commented on LUCENE-8165:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504366#comment-16504366
]
Simon Willnauer commented on LUCENE-8165:
-
+1
> ban Arrays.copyOfRange with forbidden APIs
>
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503521#comment-16503521
]
Uwe Schindler commented on LUCENE-8165:
---
+1
> ban Arrays.copyOfRange with forbidden APIs
>
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503508#comment-16503508
]
Adrien Grand commented on LUCENE-8165:
--
+1 I like it.
> ban Arrays.copyOfRange with forbidden APIs
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502419#comment-16502419
]
Nhat Nguyen commented on LUCENE-8165:
-
I've attached a new patch which removes both
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500497#comment-16500497
]
Nhat Nguyen commented on LUCENE-8165:
-
+1: {{copyOfSubArray}} to be more explicit about the fact
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500492#comment-16500492
]
Adrien Grand commented on LUCENE-8165:
--
bq. I think our code will be more clear and less
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500444#comment-16500444
]
Nhat Nguyen commented on LUCENE-8165:
-
[~rcmuir] and [~simonw]
I've submitted a new patch which
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497871#comment-16497871
]
Robert Muir commented on LUCENE-8165:
-
yeah, lets split it up.
> ban Arrays.copyOfRange with
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497861#comment-16497861
]
Simon Willnauer commented on LUCENE-8165:
-
patch looks good to me. [~rcmuir] do you wanna go
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497498#comment-16497498
]
Robert Muir commented on LUCENE-8165:
-
This looks good, thanks! I had forgotten about this issue,
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497476#comment-16497476
]
Nhat Nguyen commented on LUCENE-8165:
-
[~rcmuir] I continued your initial patch and completed the
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356399#comment-16356399
]
Robert Muir commented on LUCENE-8165:
-
For the record copyOf does similar lenient filling, but will
[
https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356376#comment-16356376
]
Robert Muir commented on LUCENE-8165:
-
attached starter patch that fixes
22 matches
Mail list logo
