[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406329#comment-16406329 ] ASF subversion and git services commented on LUCENE-8197: - Commit

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406328#comment-16406328 ] ASF subversion and git services commented on LUCENE-8197: - Commit

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406327#comment-16406327 ] Adrien Grand commented on LUCENE-8197: -- Thanks for catching [~shalinmangar]. I just fixed it. >

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406300#comment-16406300 ] Shalin Shekhar Mangar commented on LUCENE-8197: --- The CHANGES.txt mention this issue as

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406130#comment-16406130 ] ASF subversion and git services commented on LUCENE-8197: - Commit

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406129#comment-16406129 ] ASF subversion and git services commented on LUCENE-8197: - Commit

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401972#comment-16401972 ] Adrien Grand commented on LUCENE-8197: -- Thanks for the feedback. I removed the cross-field logic and

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401403#comment-16401403 ] Robert Muir commented on LUCENE-8197: - and just to be clear, i dont want to hide the formula. user

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401397#comment-16401397 ] Robert Muir commented on LUCENE-8197: - But that sounds like a more general field-weighting issue. I

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394670#comment-16394670 ] Adrien Grand commented on LUCENE-8197: -- Actually it doesn't compute avgTf on the field that stores

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394668#comment-16394668 ] Robert Muir commented on LUCENE-8197: - FWIW: the computePivotFeatureValue helper makes perfect sense

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394664#comment-16394664 ] Robert Muir commented on LUCENE-8197: - Well it seems strange what its doing: using avgTF across all

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394631#comment-16394631 ] Adrien Grand commented on LUCENE-8197: -- I don't think index statistics on this feature are

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393358#comment-16393358 ] Robert Muir commented on LUCENE-8197: - I'm confused about the first method, why wouldn't it simply

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393078#comment-16393078 ] Adrien Grand commented on LUCENE-8197: -- Thank Robert and Dawid for having a look, I folded feedback

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393059#comment-16393059 ] Dawid Weiss commented on LUCENE-8197: - We could. Sometimes it is useful, but most of the time I think

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393050#comment-16393050 ] David Smiley commented on LUCENE-8197: -- bq. If there are any associative containers those objects

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392579#comment-16392579 ] Dawid Weiss commented on LUCENE-8197: - Nice Adrien. I looked at the patch a bit late and one thing

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392154#comment-16392154 ] Robert Muir commented on LUCENE-8197: - Also i'm not sure what the explanation currently looks like

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392146#comment-16392146 ] Robert Muir commented on LUCENE-8197: - Looks much better, a few more notes on the javadocs: * Some

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391740#comment-16391740 ] Adrien Grand commented on LUCENE-8197: -- Good points, I applied your ideas. I made boosts required to

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391636#comment-16391636 ] Robert Muir commented on LUCENE-8197: - Also i would personally maybe move the guards

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391623#comment-16391623 ] Robert Muir commented on LUCENE-8197: - Great! nit on the naming: I think we should avoid