[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421300#comment-16421300
]
ASF subversion and git services commented on LUCENE-8232:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421299#comment-16421299
]
ASF subversion and git services commented on LUCENE-8232:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421219#comment-16421219
]
ASF subversion and git services commented on LUCENE-8232:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421217#comment-16421217
]
ASF subversion and git services commented on LUCENE-8232:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420861#comment-16420861
]
Michael McCandless commented on LUCENE-8232:
+1 for the internal cleanup patch, to pull
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420856#comment-16420856
]
Simon Willnauer commented on LUCENE-8232:
-
alright I will go and commit the internal cleanups
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420846#comment-16420846
]
Robert Muir commented on LUCENE-8232:
-
My concerns are primarily the apis, yes. From what i saw in
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420806#comment-16420806
]
Simon Willnauer commented on LUCENE-8232:
-
> I'm confused what the abstraction buys us. There is
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420438#comment-16420438
]
Michael McCandless commented on LUCENE-8232:
Maybe we could add a full test case showing how
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420396#comment-16420396
]
Robert Muir commented on LUCENE-8232:
-
I'm confused what the abstraction buys us. There is only one
[
https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419865#comment-16419865
]
Simon Willnauer commented on LUCENE-8232:
-
here is a link to a PR for review
11 matches
Mail list logo