[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552515#comment-16552515 ] ASF subversion and git services commented on LUCENE-8306: - Commit

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552175#comment-16552175 ] ASF subversion and git services commented on LUCENE-8306: - Commit

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552174#comment-16552174 ] ASF subversion and git services commented on LUCENE-8306: - Commit

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552166#comment-16552166 ] ASF subversion and git services commented on LUCENE-8306: - Commit

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552165#comment-16552165 ] ASF subversion and git services commented on LUCENE-8306: - Commit

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550491#comment-16550491 ] Jim Ferenczi commented on LUCENE-8306: -- +1, thanks [~romseygeek] , the patch looks good.  > Allow

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549272#comment-16549272 ] Alan Woodward commented on LUCENE-8306: --- A patch implementing the above.  Folds in the SpanQuery

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549163#comment-16549163 ] Alan Woodward commented on LUCENE-8306: --- Jim and I discussed this, and came up with the following:

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548981#comment-16548981 ] Alan Woodward commented on LUCENE-8306: --- OK, how about this: * getSubMatches() can be called at

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548104#comment-16548104 ] Jim Ferenczi commented on LUCENE-8306: -- Would it be easier if getSubMatches returns null when

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547693#comment-16547693 ] Alan Woodward commented on LUCENE-8306: --- Thanks for the review David! Re label() : yes, that's a

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546660#comment-16546660 ] David Smiley commented on LUCENE-8306: -- I did a little review: * Shouldn't label() return the

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545498#comment-16545498 ] Alan Woodward commented on LUCENE-8306: --- I ended up back where [~jimczi] suggested about a month

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543985#comment-16543985 ] David Smiley commented on LUCENE-8306: -- RE TermPostingsEnum -- haha; I see we discussed it above.

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534955#comment-16534955 ] David Smiley commented on LUCENE-8306: -- Overall sounds very good! What is TermPostingsEnum? No

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534564#comment-16534564 ] Alan Woodward commented on LUCENE-8306: --- I've been playing around with various options for this

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498024#comment-16498024 ] David Smiley commented on LUCENE-8306: -- Sounds very promising.  I'm looking forward to seeing

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497764#comment-16497764 ] Jim Ferenczi commented on LUCENE-8306: -- We discussed with [~romseygeek] about the current status

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482024#comment-16482024 ] David Smiley commented on LUCENE-8306: -- I like TermPostingsEnum.  I wish PostingsEnum simply already

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480465#comment-16480465 ] Alan Woodward commented on LUCENE-8306: --- I think of it more as adding flexibility. With this API

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480394#comment-16480394 ] Adrien Grand commented on LUCENE-8306: -- Thanks for the explanation. It still feels a bit wrong to me

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474278#comment-16474278 ] David Smiley commented on LUCENE-8306: -- {quote}Could we address this need by calling extract terms

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474116#comment-16474116 ] Adrien Grand commented on LUCENE-8306: -- bq. I think it's important, particularly if we're talking

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474058#comment-16474058 ] Alan Woodward commented on LUCENE-8306: --- bq. Can we do without this new API? I think it's

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472216#comment-16472216 ] Adrien Grand commented on LUCENE-8306: -- Alternatively could consumers call {{extractTerms}} and only

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472212#comment-16472212 ] Adrien Grand commented on LUCENE-8306: -- I suspect such an API won't be easy to implement eg. on

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470627#comment-16470627 ] David Smiley commented on LUCENE-8306: -- Aha; so this is the solution highlighters need.  A good

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470358#comment-16470358 ] Alan Woodward commented on LUCENE-8306: --- Here's a patch with an outline for an API.