[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-23 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488258#comment-16488258 ] Lucene/Solr QA commented on LUCENE-8328: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-23 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487143#comment-16487143 ] Nhat Nguyen commented on LUCENE-8328: - Thanks [~simonw] > ReadersAndUpdates#getLatestReader should

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486754#comment-16486754 ] ASF subversion and git services commented on LUCENE-8328: - Commit

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486752#comment-16486752 ] ASF subversion and git services commented on LUCENE-8328: - Commit

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486734#comment-16486734 ] Simon Willnauer commented on LUCENE-8328: - this looks great [~dnhatn] I will push this today >

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486519#comment-16486519 ] Nhat Nguyen commented on LUCENE-8328: - [~simonw] I've updated the test. >

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484618#comment-16484618 ] Nhat Nguyen commented on LUCENE-8328: - Sure. I will look at that test class. >

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484603#comment-16484603 ] Simon Willnauer commented on LUCENE-8328: - +1 good catch. I do wonder if we can get a test that

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484572#comment-16484572 ] Nhat Nguyen commented on LUCENE-8328: - /cc [~simonw] > ReadersAndUpdates#getLatestReader should