[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-06-04 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501310#comment-16501310 ] Lucene/Solr QA commented on LUCENE-8341: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-06-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500189#comment-16500189 ] ASF subversion and git services commented on LUCENE-8341: - Commit

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-06-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500186#comment-16500186 ] ASF subversion and git services commented on LUCENE-8341: - Commit

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-06-04 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499821#comment-16499821 ] Simon Willnauer commented on LUCENE-8341: - new patch incorporating

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-06-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498621#comment-16498621 ] Michael McCandless commented on LUCENE-8341: +1, looks great! > Record soft deletes in

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-06-01 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498140#comment-16498140 ] Lucene/Solr QA commented on LUCENE-8341: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-05-31 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497240#comment-16497240 ] Simon Willnauer commented on LUCENE-8341: - {quote} Yes I agree it is a shame CheckIndex cannot

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-05-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497237#comment-16497237 ] Robert Muir commented on LUCENE-8341: - Yes I agree it is a shame CheckIndex cannot enforce the check

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-05-31 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497200#comment-16497200 ] Simon Willnauer commented on LUCENE-8341: - [~mikemccand] I added an option to checkindex that is

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-05-31 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496958#comment-16496958 ] Simon Willnauer commented on LUCENE-8341: - {quote}Why did you need the

[jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo

2018-05-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496701#comment-16496701 ] Michael McCandless commented on LUCENE-8341: +1 Maybe add javadocs for the new