[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611122#comment-16611122
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610989#comment-16610989
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610986#comment-16610986
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610987#comment-16610987
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610988#comment-16610988
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610984#comment-16610984
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610985#comment-16610985
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610983#comment-16610983
]
ASF subversion and git services commented on LUCENE-8343:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610825#comment-16610825
]
Michael McCandless commented on LUCENE-8343:
Thanks [~alessandro.benedetti]; I'll have a
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609825#comment-16609825
]
Lucene/Solr QA commented on LUCENE-8343:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609752#comment-16609752
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi [~mikemccand], sorry for the immense
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609554#comment-16609554
]
Michael McCandless commented on LUCENE-8343:
[~alessandro.benedetti] if you can resolve the
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572459#comment-16572459
]
Michael McCandless commented on LUCENE-8343:
Thanks [~alessandro.benedetti] – the latest
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562615#comment-16562615
]
Michael McCandless commented on LUCENE-8343:
Thank you [~alessandro.benedetti] I'll have a
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562096#comment-16562096
]
Lucene/Solr QA commented on LUCENE-8343:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561918#comment-16561918
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi [~mikemccand], I just updated the Pull
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549655#comment-16549655
]
Lucene/Solr QA commented on LUCENE-8343:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549498#comment-16549498
]
Michael McCandless commented on LUCENE-8343:
Hi [~alessandro.benedetti], it looks like there
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547613#comment-16547613
]
Michael McCandless commented on LUCENE-8343:
Thank you [~alessandro.benedetti]!
>
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547600#comment-16547600
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi [~mikemccand],
I just merged the branch
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541816#comment-16541816
]
Michael McCandless commented on LUCENE-8343:
Hi [~alessandro.benedetti], sorry for the
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534631#comment-16534631
]
Alessandro Benedetti commented on LUCENE-8343:
--
Any update on this ? Can I help anyway with
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513663#comment-16513663
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi [~mikemccand], thanks for your review !
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512583#comment-16512583
]
Michael McCandless commented on LUCENE-8343:
I like the change in the PR; I left small
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511583#comment-16511583
]
Michael McCandless commented on LUCENE-8343:
Woops sorry [~alessandro.benedetti]; I missed
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510863#comment-16510863
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi [~mikemccand], thank you for your
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510024#comment-16510024
]
Michael McCandless commented on LUCENE-8343:
I agree the proposed fix seems somewhat hacky;
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506129#comment-16506129
]
Alessandro Benedetti commented on LUCENE-8343:
--
First of all, thanks again Adrien for your
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506007#comment-16506007
]
Lucene/Solr QA commented on LUCENE-8343:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505893#comment-16505893
]
Adrien Grand commented on LUCENE-8343:
--
[~mikemccand] What do you think would be the right fix?
>
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505885#comment-16505885
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi Adrien,
I theoretically agree with you.
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505868#comment-16505868
]
Adrien Grand commented on LUCENE-8343:
--
Thanks for the explanations. I 'm not familiar enough with
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505016#comment-16505016
]
Alessandro Benedetti commented on LUCENE-8343:
--
In the meantime I attached the patch with
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504909#comment-16504909
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi [~jpountz],
thanks for your time, I can
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504852#comment-16504852
]
Alessandro Benedetti commented on LUCENE-8343:
--
Hi Cassandra,
I did the change and pushed,
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504840#comment-16504840
]
Adrien Grand commented on LUCENE-8343:
--
I'm not very familiar with this suggester so I might be
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504819#comment-16504819
]
Cassandra Targett commented on LUCENE-8343:
---
[~alessandro.benedetti] - you mentioned on
[
https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499070#comment-16499070
]
Lucene/Solr QA commented on LUCENE-8343:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
38 matches
Mail list logo
