[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553059#comment-16553059 ] Alan Woodward commented on LUCENE-8401: --- Here's an updated patch taking into account feedback.  I

[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-18 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547916#comment-16547916 ] David Smiley commented on LUCENE-8401: -- Yeah it's up to a pluggable passage formatter to either

[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-18 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547514#comment-16547514 ] Dawid Weiss commented on LUCENE-8401: - bq. I wonder how interleaved hits should be handled. Just

[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-18 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547486#comment-16547486 ] Jim Ferenczi commented on LUCENE-8401: -- I like the approach here. A few comments: * The text

[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545682#comment-16545682 ] David Smiley commented on LUCENE-8401: -- Along the idea of reusable components, adding a

[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545661#comment-16545661 ] David Smiley commented on LUCENE-8401: -- This is a fine idea Alan. I especially like the peeking

[jira] [Commented] (LUCENE-8401) Add PassageBuilder to help construct highlights using MatchesIterator

2018-07-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545040#comment-16545040 ] Alan Woodward commented on LUCENE-8401: --- Here is a patch containing the following classes: *