[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686154#comment-16686154 ] ASF subversion and git services commented on LUCENE-8560: - Commit

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683654#comment-16683654 ] ASF subversion and git services commented on LUCENE-8560: - Commit

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-10 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682486#comment-16682486 ] Uwe Schindler commented on LUCENE-8560: --- I have no strong preference. Maybe keep the class but

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-10 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682480#comment-16682480 ] Dawid Weiss commented on LUCENE-8560: - Applied the patch to master branch. Should we backport it as

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682479#comment-16682479 ] ASF subversion and git services commented on LUCENE-8560: - Commit

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-09 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681896#comment-16681896 ] Dawid Weiss commented on LUCENE-8560: - Here's a patch that shows what it looks like after removal of

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-09 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681803#comment-16681803 ] Uwe Schindler commented on LUCENE-8560: --- +1 to nuke it. Otherwise change the impl to be correct

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-09 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681789#comment-16681789 ] Steve Rowe commented on LUCENE-8560: +1 to nuke ByteArrayIndexInput [~dweiss], in both cases users

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-09 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681178#comment-16681178 ] Dawid Weiss commented on LUCENE-8560: - Hmm... So ByteArrayIndexInput is only used in two places: in

[jira] [Commented] (LUCENE-8560) TestByteBuffersDirectory.testSeekPastEOF() failures with ByteArrayIndexInput

2018-11-08 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680985#comment-16680985 ] Dawid Weiss commented on LUCENE-8560: - The comment wasn't written by me, actually. It's historically