[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734555#comment-16734555 ] Lucene/Solr QA commented on LUCENE-8601: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734391#comment-16734391 ] ASF subversion and git services commented on LUCENE-8601: - Commit

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734103#comment-16734103 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat] – I'll review and push

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734046#comment-16734046 ] Murali Krishna P commented on LUCENE-8601: -- Thanks [~mikemccand]. Uploaded a separate patch for

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733641#comment-16733641 ] Michael McCandless commented on LUCENE-8601: Hi [~muralikpbhat], I pushed the change to

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733635#comment-16733635 ] ASF subversion and git services commented on LUCENE-8601: - Commit

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731696#comment-16731696 ] Michael McCandless commented on LUCENE-8601: Thanks I will review and push soon! > Adding

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731626#comment-16731626 ] Lucene/Solr QA commented on LUCENE-8601: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731518#comment-16731518 ] Murali Krishna P commented on LUCENE-8601: -- Thanks, Added java docs for ignoreCurrentFormat,

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731288#comment-16731288 ] Michael McCandless commented on LUCENE-8601: Ahh OK thanks [~muralikpbhat]; that makes

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730866#comment-16730866 ] Murali Krishna P commented on LUCENE-8601: -- Thanks Mike, regarding the assertion, i indeed

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730210#comment-16730210 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]! Maybe add javadocs

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730028#comment-16730028 ] Murali Krishna P commented on LUCENE-8601: -- [^LUCENE-8601.05.patch] which retains the

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729119#comment-16729119 ] Lucene/Solr QA commented on LUCENE-8601: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728862#comment-16728862 ] Murali Krishna P commented on LUCENE-8601: -- You are right, [~mikemccand]. The FieldInfo has an

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725297#comment-16725297 ] Michael McCandless commented on LUCENE-8601: Hmm, I'm concerned that segment merging may not

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725251#comment-16725251 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]; new patch looks good

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724142#comment-16724142 ] Lucene/Solr QA commented on LUCENE-8601: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723651#comment-16723651 ] Murali Krishna P commented on LUCENE-8601: -- Good catch [~jpountz], fixed it and modified the

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723036#comment-16723036 ] Adrien Grand commented on LUCENE-8601: -- Should the copy constructor of FieldType clone the

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723009#comment-16723009 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]; new patch looks great. 

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722961#comment-16722961 ] Murali Krishna P commented on LUCENE-8601: -- Done that change [^LUCENE-8601.03.patch], thank

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722893#comment-16722893 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]; can we make the

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722670#comment-16722670 ] Murali Krishna P commented on LUCENE-8601: -- Thanks [~mikemccand] for reviewing. Added the

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721504#comment-16721504 ] Michael McCandless commented on LUCENE-8601: Patch looks great [~muralikpbhat]; impressive

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719896#comment-16719896 ] Murali Krishna P commented on LUCENE-8601: -- Lucene precommit Jenkins seems to be waiting for

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718913#comment-16718913 ] Murali Krishna P commented on LUCENE-8601: -- Fixed the failing test and solr. > Adding

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716998#comment-16716998 ] Lucene/Solr QA commented on LUCENE-8601: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||