[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753786#comment-16753786
]
ASF subversion and git services commented on LUCENE-8640:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753785#comment-16753785
]
ASF subversion and git services commented on LUCENE-8640:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753783#comment-16753783
]
ASF subversion and git services commented on LUCENE-8640:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753771#comment-16753771
]
Adrien Grand commented on LUCENE-8640:
--
+1
> validate delimiters when parsing date ranges
>
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753749#comment-16753749
]
Mikhail Khludnev commented on LUCENE-8640:
--
oh, yeah.. it doesn't get well with dinosaurs era
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753746#comment-16753746
]
Adrien Grand commented on LUCENE-8640:
--
[~mkhludnev] This change is causing failures on branch_7x,
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753546#comment-16753546
]
ASF subversion and git services commented on LUCENE-8640:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753544#comment-16753544
]
ASF subversion and git services commented on LUCENE-8640:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753541#comment-16753541
]
ASF subversion and git services commented on LUCENE-8640:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753483#comment-16753483
]
David Smiley commented on LUCENE-8640:
--
+1
> validate delimiters when parsing date ranges
>
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753460#comment-16753460
]
Lucene/Solr QA commented on LUCENE-8640:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753163#comment-16753163
]
Mikhail Khludnev commented on LUCENE-8640:
--
tweaked [^LUCENE-8640.patch] a little, will commit
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749394#comment-16749394
]
Lucky Sharma commented on LUCENE-8640:
--
I have incorporated the comments :) please review
>
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749060#comment-16749060
]
Mikhail Khludnev commented on LUCENE-8640:
--
[~lsharma3] I left a few comments on github, would
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747380#comment-16747380
]
Lucky Sharma commented on LUCENE-8640:
--
[~dsmiley] Sure, I have updated the same in the new patch
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747335#comment-16747335
]
David Smiley commented on LUCENE-8640:
--
Better but still the integer gets parsed twice. I suggest
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747305#comment-16747305
]
Lucky Sharma commented on LUCENE-8640:
--
[~dsmiley][~mkhludnev] I have updated the patch. Please
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746960#comment-16746960
]
Lucky Sharma commented on LUCENE-8640:
--
Sure ,I am already onto it, Will be uploading the patch.
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746671#comment-16746671
]
David Smiley commented on LUCENE-8640:
--
I was also hoping it would validate as it parses. I think
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746059#comment-16746059
]
Lucky Sharma commented on LUCENE-8640:
--
Sure, I was unaware of the pattern for the patch file, Will
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745943#comment-16745943
]
Mikhail Khludnev commented on LUCENE-8640:
--
Thanks for the contribution!. For matter of taste,
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744039#comment-16744039
]
Lucky Sharma commented on LUCENE-8640:
--
yes
> validate delimiters when parsing date ranges
>
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743949#comment-16743949
]
Mikhail Khludnev commented on LUCENE-8640:
--
does it pass Solr's DateRangeFieldTest ?
>
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743898#comment-16743898
]
Lucky Sharma commented on LUCENE-8640:
--
Please review the patch for the same
> validate delimiters
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743867#comment-16743867
]
Lucky Sharma commented on LUCENE-8640:
--
[~mkhludnev] will this be count as a valid date
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743765#comment-16743765
]
Lucky Sharma commented on LUCENE-8640:
--
Sure that will be fine then.
> validate delimiters when
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743757#comment-16743757
]
Lucky Sharma commented on LUCENE-8640:
--
Should we reject the date completely? or just we can send
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743764#comment-16743764
]
Mikhail Khludnev commented on LUCENE-8640:
--
reject it absolutely since we parting a *range* not
28 matches
Mail list logo
