[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818361#comment-16818361
]
ASF subversion and git services commented on LUCENE-8671:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818265#comment-16818265
]
ASF subversion and git services commented on LUCENE-8671:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809955#comment-16809955
]
ASF subversion and git services commented on LUCENE-8671:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809947#comment-16809947
]
ASF subversion and git services commented on LUCENE-8671:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797030#comment-16797030
]
ASF subversion and git services commented on LUCENE-8671:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797017#comment-16797017
]
ASF subversion and git services commented on LUCENE-8671:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788340#comment-16788340
]
Ankit Jain commented on LUCENE-8671:
[~simonw] [~mikemccand] I have created PR -
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786133#comment-16786133
]
Ankit Jain commented on LUCENE-8671:
bq. We can then pass it down to the relevant parts and make it
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785703#comment-16785703
]
Simon Willnauer commented on LUCENE-8671:
-
I don't think we should add a setter to FieldInfo.
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775680#comment-16775680
]
Ankit Jain commented on LUCENE-8671:
bq. Ankit Jain We could maybe add a setter on
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775190#comment-16775190
]
Michael McCandless commented on LUCENE-8671:
[~akjain] that's true, maybe we don't need
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774457#comment-16774457
]
David Smiley commented on LUCENE-8671:
--
+1 to use attributes. Thanks Mike; I should have thought
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772641#comment-16772641
]
Ankit Jain commented on LUCENE-8671:
[~mikemccand] Also, I'm wondering if we need per field setting
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772384#comment-16772384
]
Ankit Jain commented on LUCENE-8671:
bq. But can you use the existing attributes instead of adding a
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772068#comment-16772068
]
Michael McCandless commented on LUCENE-8671:
Actually I think this is a good use case for
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764055#comment-16764055
]
Ankit Jain commented on LUCENE-8671:
Hi David,
Thanks for the feedback.
{quote}Modifying FieldInfo
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762387#comment-16762387
]
David Smiley commented on LUCENE-8671:
--
Hi,
Modifying FieldInfo feels wrong to me. This is a
[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762028#comment-16762028
]
Ankit Jain commented on LUCENE-8671:
I have added [^offheap_settings.patch] that allows user to pass
18 matches
Mail list logo