[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877096#comment-16877096 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876689#comment-16876689 ] Adrien Grand commented on LUCENE-8757: -- This change as been reverted from 8.x due to the fact that

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876685#comment-16876685 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876688#comment-16876688 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860181#comment-16860181 ] Atri Sharma commented on LUCENE-8757: - [~hossman] This is a known issue

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860173#comment-16860173 ] Hoss Man commented on LUCENE-8757: -- another similar failure...

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860166#comment-16860166 ] Hoss Man commented on LUCENE-8757: -- git bisect has identified cfd9de894d1f0f1b9e368994b972a81f449c

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846494#comment-16846494 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845726#comment-16845726 ] Atri Sharma commented on LUCENE-8757: - [~jpountz] Thanks for pushing! > Better Segment To Thread

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845599#comment-16845599 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845598#comment-16845598 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845120#comment-16845120 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845113#comment-16845113 ] ASF subversion and git services commented on LUCENE-8757: - Commit

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844849#comment-16844849 ] Atri Sharma commented on LUCENE-8757: - [^LUCENE-8757.patch] > Better Segment To Thread Mapping

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844848#comment-16844848 ] Atri Sharma commented on LUCENE-8757: - [~jpountz] Essentially, the idea is to maintain the previous

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844595#comment-16844595 ] Adrien Grand commented on LUCENE-8757: -- [~atris] I think it is still not correct since the values

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844470#comment-16844470 ] Atri Sharma commented on LUCENE-8757: - [^LUCENE-8757.patch]   [~jpountz] Updated the assert,

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844198#comment-16844198 ] Adrien Grand commented on LUCENE-8757: -- Thanks [~atris]. I think there is a bug in

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844048#comment-16844048 ] Atri Sharma commented on LUCENE-8757: - Added both, a test and the assertion in AssertingCollector.  

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844013#comment-16844013 ] Adrien Grand commented on LUCENE-8757: -- I think we could add an assertion for this in

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844005#comment-16844005 ] Michael McCandless commented on LUCENE-8757: {quote}Your last patch sorts in reverse order

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843886#comment-16843886 ] Atri Sharma commented on LUCENE-8757: - Yeah, I noted that after posting the patch. Attached is an

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843876#comment-16843876 ] Adrien Grand commented on LUCENE-8757: -- [~atris] Your last patch sorts in reverse order of docBase,

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843807#comment-16843807 ] Atri Sharma commented on LUCENE-8757: - [~simonw] Attached is an updated patch  

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843726#comment-16843726 ] Simon Willnauer commented on LUCENE-8757: - [~atris] can we instead of asserting the order just

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840683#comment-16840683 ] Atri Sharma commented on LUCENE-8757: - Hi [~jpountz], I was going through IndexSearcher code and

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838419#comment-16838419 ] Atri Sharma commented on LUCENE-8757: - [~jpountz] Thanks, TopDocs#merge is what really opened my

Re: [jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

I think this should be done inside IndexSearcher. It’s a general problem, no? > On 13. May 2019, at 10:25, Adrien Grand (JIRA) wrote: > > >[ > https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838363#comment-16838363

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838363#comment-16838363 ] Adrien Grand commented on LUCENE-8757: -- Yes. Top-docs collectors are expected to tie-break by doc

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838240#comment-16838240 ] Atri Sharma commented on LUCENE-8757: - [~jpountz] Do you mean ordering segments within a slice by

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838131#comment-16838131 ] Adrien Grand commented on LUCENE-8757: -- I think we need to sort by docBase before constructing the

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837615#comment-16837615 ] Simon Willnauer commented on LUCENE-8757: - LGTM I will try to commit this in the coming days >

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837056#comment-16837056 ] Atri Sharma commented on LUCENE-8757: - Added the segments cap back with additional random testing.  

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837003#comment-16837003 ] Simon Willnauer commented on LUCENE-8757: - {quote} I think there is an important justification

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836281#comment-16836281 ] Atri Sharma commented on LUCENE-8757: - [~simonw] Please let me know if you have any further

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835508#comment-16835508 ] Atri Sharma commented on LUCENE-8757: - bq. Are the work units tackled in order for each query? I.e.

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835502#comment-16835502 ] Michael McCandless commented on LUCENE-8757: Are the work units tackled in order for each

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835498#comment-16835498 ] Michael McCandless commented on LUCENE-8757: Whoa, fast iterations over here! I think there

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835491#comment-16835491 ] Atri Sharma commented on LUCENE-8757: - [~simonw] The reason the sort was added was to have a

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835481#comment-16835481 ] Simon Willnauer commented on LUCENE-8757: - Thanks for the additional iteration, now that we

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834856#comment-16834856 ] Atri Sharma commented on LUCENE-8757: - Hi [~simonw] bq. if the previous segment was smallish then

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834767#comment-16834767 ] Simon Willnauer commented on LUCENE-8757: - [~atris] I think the assertion in this part doesn't

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834587#comment-16834587 ] Atri Sharma commented on LUCENE-8757: - [~simonw] The reasoning behind adding the second parameter

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834525#comment-16834525 ] Simon Willnauer commented on LUCENE-8757: - [~atris] actually I thought about these defaults

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834463#comment-16834463 ] Atri Sharma commented on LUCENE-8757: - :bq  I don't think we should push this if we already know we

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1683#comment-1683 ] Simon Willnauer commented on LUCENE-8757: - > Would it make sense to push this patch, and then

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834065#comment-16834065 ] Atri Sharma commented on LUCENE-8757: - Hi [~simonw],   Spending a bit more time thinking about

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832382#comment-16832382 ] Atri Sharma commented on LUCENE-8757: - [~simonw] Attached is an updated patch. My two cents are

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832343#comment-16832343 ] Simon Willnauer commented on LUCENE-8757: - Thanks [~atris], can you bring back the javadocs for 

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832233#comment-16832233 ] Atri Sharma commented on LUCENE-8757: - [^LUCENE-8757.patch]Hi [~simonw]   Thanks for reviewing the

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831591#comment-16831591 ] Simon Willnauer commented on LUCENE-8757: - Hey Atri, thanks for putting up this patch, here is

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830958#comment-16830958 ] Atri Sharma commented on LUCENE-8757: - Hi [~mikemccand]   Thanks for taking a look at the patch. I

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830173#comment-16830173 ] Michael McCandless commented on LUCENE-8757: Thanks [~atris] – I agree it's important to

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823295#comment-16823295 ] Atri Sharma commented on LUCENE-8757: - Attached is a first cut for the patch. The main idea there is