[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844085#comment-16844085
]
Namgyu Kim commented on LUCENE-8805:
Sure. I will just work on stringField and update the patch.
[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844072#comment-16844072
]
Robert Muir commented on LUCENE-8805:
-
We could do the String case here and leave the BytesRef case
[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844051#comment-16844051
]
Namgyu Kim commented on LUCENE-8805:
Thank you for your reply, [~jpountz].
Yes. I agree with you :D
[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843931#comment-16843931
]
Adrien Grand commented on LUCENE-8805:
--
I like how passing a String to stringField makes the API
[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843485#comment-16843485
]
Namgyu Kim commented on LUCENE-8805:
Thank you for your reply, and I'm sorry for late reply.
[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843218#comment-16843218
]
Robert Muir commented on LUCENE-8805:
-
Another idea: we may want to add some tests where we pass
[
https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843217#comment-16843217
]
Robert Muir commented on LUCENE-8805:
-
Should we add any safety checks? With the previous code,
