[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998600#comment-15998600
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998594#comment-15998594
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972946#comment-15972946
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution closed the pull request at:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972944#comment-15972944
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966442#comment-15966442
]
Joel Bernstein commented on SOLR-10303:
---
[~dpgove], it's all committed now. Feel free to change
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966428#comment-15966428
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966430#comment-15966430
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966432#comment-15966432
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966434#comment-15966434
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966433#comment-15966433
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966437#comment-15966437
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966431#comment-15966431
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966435#comment-15966435
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966429#comment-15966429
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966427#comment-15966427
]
ASF subversion and git services commented on SOLR-10303:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966378#comment-15966378
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user joel-bernstein commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966377#comment-15966377
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966375#comment-15966375
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user joel-bernstein commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966373#comment-15966373
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960524#comment-15960524
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959557#comment-15959557
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959098#comment-15959098
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959032#comment-15959032
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959004#comment-15959004
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958704#comment-15958704
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958570#comment-15958570
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958568#comment-15958568
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958567#comment-15958567
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958565#comment-15958565
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user covolution commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957541#comment-15957541
]
Dennis Gove commented on SOLR-10303:
[~covolution] I'm sorry. I forgot to submit the review on Github.
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957534#comment-15957534
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957533#comment-15957533
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957535#comment-15957535
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957536#comment-15957536
]
ASF GitHub Bot commented on SOLR-10303:
---
Github user dennisgove commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957531#comment-15957531
]
Gethin James commented on SOLR-10303:
-
Sorry, I can't find any comments on the pull request.
> Add
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956946#comment-15956946
]
Dennis Gove commented on SOLR-10303:
In case you missed them, I added comments to the PR at
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956929#comment-15956929
]
Gethin James commented on SOLR-10303:
-
1) I like the idea of a TupleContext which the SelectStream can
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954260#comment-15954260
]
Joel Bernstein commented on SOLR-10303:
---
I really like the design of this. A couple things to think
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933087#comment-15933087
]
Gethin James commented on SOLR-10303:
-
We could do with some documentation! Here is a start:
Date
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932996#comment-15932996
]
ASF GitHub Bot commented on SOLR-10303:
---
GitHub user covolution opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932130#comment-15932130
]
Dennis Gove commented on SOLR-10303:
For the function names, any concern with using pascal casing for
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930237#comment-15930237
]
Gethin James commented on SOLR-10303:
-
I renamed the evaluator as suggested and added support for
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929963#comment-15929963
]
Dennis Gove commented on SOLR-10303:
Can we call this a DatePartEvaluator?
This seems to only work on
[
https://issues.apache.org/jira/browse/SOLR-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929941#comment-15929941
]
Gethin James commented on SOLR-10303:
-
I started working on this. With support for:
{code}year,
44 matches
Mail list logo