[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787663#comment-16787663
]
ASF subversion and git services commented on SOLR-10506:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787666#comment-16787666
]
ASF subversion and git services commented on SOLR-10506:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064888#comment-16064888
]
ASF subversion and git services commented on SOLR-10506:
Commit
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063199#comment-16063199
]
Christine Poerschke commented on SOLR-10506:
+1 to having a non-empty message in general,
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063188#comment-16063188
]
ASF GitHub Bot commented on SOLR-10506:
---
Github user tboeghk commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063170#comment-16063170
]
ASF GitHub Bot commented on SOLR-10506:
---
Github user uschindler commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035222#comment-16035222
]
Christine Poerschke commented on SOLR-10506:
bq. ... to have as a separate issue ...
bq. ...
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019247#comment-16019247
]
Jörg Rathlev commented on SOLR-10506:
-
bq. Nice. Just wondering if SchemaWatcher objects are also not
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017804#comment-16017804
]
Mike Drob commented on SOLR-10506:
--
+1 LGTM. [~cpoerschke], I'll let you commit this when you are done
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017757#comment-16017757
]
Christine Poerschke commented on SOLR-10506:
bq. ... Based on testing this with a memory
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015480#comment-16015480
]
Jörg Rathlev commented on SOLR-10506:
-
I've updated my branch so that the reference in the
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004852#comment-16004852
]
Jörg Rathlev commented on SOLR-10506:
-
Oh, right, good point! So, the SchemaWatcher needs to keep a
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004822#comment-16004822
]
Mike Drob commented on SOLR-10506:
--
Well, the stopWatching method is only called when a core is closed.
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004552#comment-16004552
]
Torsten Bøgh Köster commented on SOLR-10506:
Thanks Joerg & Christine for digging into this!
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004527#comment-16004527
]
Jörg Rathlev commented on SOLR-10506:
-
Based off upstream/master:
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004503#comment-16004503
]
Jörg Rathlev commented on SOLR-10506:
-
bq. Interesting idea to re-use the watcher like that. That
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004456#comment-16004456
]
Mike Drob commented on SOLR-10506:
--
Since it's a weak reference, couldn't the schema reader be collected
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004451#comment-16004451
]
Christine Poerschke commented on SOLR-10506:
bq. ... implement the command method in
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002538#comment-16002538
]
Jörg Rathlev commented on SOLR-10506:
-
I'd suggest to simply implement the command method in
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997269#comment-15997269
]
Christine Poerschke commented on SOLR-10506:
bq. ... removing a submitted Zookeeper watcher
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996607#comment-15996607
]
Torsten Bøgh Köster commented on SOLR-10506:
Hi Christine,
thanks for the suggestions, I
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996576#comment-15996576
]
ASF GitHub Bot commented on SOLR-10506:
---
Github user tboeghk commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996577#comment-15996577
]
ASF GitHub Bot commented on SOLR-10506:
---
Github user tboeghk closed the pull request at:
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996574#comment-15996574
]
ASF GitHub Bot commented on SOLR-10506:
---
GitHub user tboeghk opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985007#comment-15985007
]
Christine Poerschke commented on SOLR-10506:
Hi Torsten, thanks for finding and analysing this
[
https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972465#comment-15972465
]
ASF GitHub Bot commented on SOLR-10506:
---
GitHub user tboeghk opened a pull request:
26 matches
Mail list logo
