[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-24 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062125#comment-16062125 ] Mikhail Khludnev commented on SOLR-10915: - ok. Sorry for buzz, [~anshumg]. {{ant clean}} fixed it.

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-24 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062058#comment-16062058 ] Anshum Gupta commented on SOLR-10915: - [~mkhludnev] did you intend to comment on this JIRA? On a side

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-24 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062048#comment-16062048 ] Mikhail Khludnev commented on SOLR-10915: - I want to commit on top of {code} commit

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061355#comment-16061355 ] ASF subversion and git services commented on SOLR-10915: Commit

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-23 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061165#comment-16061165 ] Anshum Gupta commented on SOLR-10915: - I'm seeing some pre-commit failures. I've fixed a couple of

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056564#comment-16056564 ] Anshum Gupta commented on SOLR-10915: - There's existing constructors that were released in 6.6, which

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056496#comment-16056496 ] Anshum Gupta commented on SOLR-10915: - [~gerlowskija] one more thing, can you have the extension of

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056210#comment-16056210 ] Anshum Gupta commented on SOLR-10915: - Sorry about that confusion, should've read what I wrote :). I

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056201#comment-16056201 ] Jason Gerlowski commented on SOLR-10915: I think I'm reading you wrong. bq. we should only have

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056177#comment-16056177 ] Anshum Gupta commented on SOLR-10915: - Thanks Jason. The patch looks good overall but I think we

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056053#comment-16056053 ] Jason Gerlowski commented on SOLR-10915: A few responses: bq. Where a Builder class has been

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056009#comment-16056009 ] Shawn Heisey commented on SOLR-10915: - If I'm understanding what's going on here, I really like it. I

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-20 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055713#comment-16055713 ] Jason Gerlowski commented on SOLR-10915: (Both patches contain the CloudSolrClient visibility

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-19 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054452#comment-16054452 ] Jason Gerlowski commented on SOLR-10915: That all makes sense; I'll do this later today (folding

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-19 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054443#comment-16054443 ] Anshum Gupta commented on SOLR-10915: - Also, SOLR-9535 seems to overlap with this to a reasonable

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-19 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054432#comment-16054432 ] Anshum Gupta commented on SOLR-10915: - [~gerlowskija], ideally I'd want to build my extended client

[jira] [Commented] (SOLR-10915) Make SolrClient classes extendable without code duplication

2017-06-19 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054373#comment-16054373 ] Jason Gerlowski commented on SOLR-10915: Yes, this is true. Most (see below) of the SolrClient