[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793830#comment-16793830 ] Kevin Risden commented on SOLR-11763: - Side note found the comment about "8.x" fix version while

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793797#comment-16793797 ] David Smiley commented on SOLR-11763: - Yeah something like that.  Here's what I suggest: # un-assign

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793767#comment-16793767 ] Kevin Risden commented on SOLR-11763: - You might be right. I thought there was an email about using

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793758#comment-16793758 ] David Smiley commented on SOLR-11763: - The Fix version here is wrong; it should point to a specific

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772432#comment-16772432 ] Markus Jelsma commented on SOLR-11763: -- Thanks! > Upgrade Guava to 25.1-jre >

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772400#comment-16772400 ] ASF subversion and git services commented on SOLR-11763: Commit

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772390#comment-16772390 ] ASF subversion and git services commented on SOLR-11763: Commit

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762805#comment-16762805 ] Uwe Schindler commented on SOLR-11763: -- I am fine with the patch. The new suffix "-jre" on Guava is

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762778#comment-16762778 ] Kevin Risden commented on SOLR-11763: - No worries :) Thanks for checking. I've been trying to track

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762540#comment-16762540 ] Markus Jelsma commented on SOLR-11763: -- Sigh, my apologies [~krisden], i didn't notice my revision

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761796#comment-16761796 ] Kevin Risden commented on SOLR-11763: - [~markus17] - I cloned the lucene-solr repo into a separate

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759947#comment-16759947 ] Markus Jelsma commented on SOLR-11763: -- The patch goes well for all files on master and 7.6 except

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759938#comment-16759938 ] Kevin Risden commented on SOLR-11763: - [~markus17] thanks for the quick check. I'll have to take a

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759934#comment-16759934 ] Markus Jelsma commented on SOLR-11763: -- Hello [~krisden], the patch fails for 7.6 and master:

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759928#comment-16759928 ] Kevin Risden commented on SOLR-11763: - [~markus17] [~elyograg] [~varunthacker] [~thetaphi] - Any

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759554#comment-16759554 ] Lucene/Solr QA commented on SOLR-11763: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759241#comment-16759241 ] Kevin Risden commented on SOLR-11763: - Latest patch upgrades curator and adds license/notice for

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759239#comment-16759239 ] Kevin Risden commented on SOLR-11763: - Curator uses Guava and in the version we are using it is not

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759209#comment-16759209 ] Kevin Risden commented on SOLR-11763: - PR is based on apache branch jira/solr-11763. I have checked

[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre

[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759202#comment-16759202 ] Kevin Risden commented on SOLR-11763: - In the Apache Knox project we have integration tests with