[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423749#comment-16423749 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418820#comment-16418820 ] Andrzej Bialecki commented on SOLR-11882: -- Patch for branch_7x that allows us to maintain

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417100#comment-16417100 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416468#comment-16416468 ] Andrzej Bialecki commented on SOLR-11882: -- Updated patch. This adds a SolrCore instance

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416355#comment-16416355 ] Andrzej Bialecki commented on SOLR-11882: -- bq. Could we introspect the impl and do the right

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416335#comment-16416335 ] Mark Miller commented on SOLR-11882: bq. definitely not for 7.3. Could we introspect the impl and do

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416320#comment-16416320 ] Andrzej Bialecki commented on SOLR-11882: -- [~romseygeek] The current patch is broken (Solr

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415849#comment-16415849 ] Erick Erickson commented on SOLR-11882: --- [~romseygeek] This has been around since at least 6.4 I

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415225#comment-16415225 ] Andrzej Bialecki commented on SOLR-11882: -- [~romseygeek] the patch appears to be working but as

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415218#comment-16415218 ] Alan Woodward commented on SOLR-11882: -- This looks like a pretty serious bug.  I'm going to build

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414314#comment-16414314 ] Erick Erickson commented on SOLR-11882: --- [~ab] LGTM, after I cycle through my tests (and do a GC),

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413869#comment-16413869 ] Andrzej Bialecki commented on SOLR-11882: -- Here's the setup that I used to test and verify this

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402474#comment-16402474 ] Erick Erickson commented on SOLR-11882: --- [~ab] Here's a one-line fix that I don't particularly like

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399440#comment-16399440 ] Erick Erickson commented on SOLR-11882: --- [~ab] OK, I think the light finally dawned. We're talking

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348957#comment-16348957 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348956#comment-16348956 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348931#comment-16348931 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348930#comment-16348930 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348848#comment-16348848 ] Erick Erickson commented on SOLR-11882: --- OK, let's revert this. I am traveling today, so feel free

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348833#comment-16348833 ] Andrzej Bialecki commented on SOLR-11882: -- It turns out that this fix is wrong... :( The new

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342864#comment-16342864 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342863#comment-16342863 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342855#comment-16342855 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342856#comment-16342856 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342853#comment-16342853 ] ASF subversion and git services commented on SOLR-11882: Commit

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342852#comment-16342852 ] Erick Erickson commented on SOLR-11882: --- Patch with CHANGES.txt > SolrMetric registries retain

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342313#comment-16342313 ] Erick Erickson commented on SOLR-11882: --- Any reason _not_ to commit this? Otherwise I'll commit this

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338504#comment-16338504 ] Erick Erickson commented on SOLR-11882: --- Oh total bother. I put up a second copy of the _same_ hack

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337190#comment-16337190 ] Andrzej Bialecki commented on SOLR-11882: -- {quote}[~ab]kindly provided this suggestion, I

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337104#comment-16337104 ] Eros Taborelli commented on SOLR-11882: --- [~erickerickson] yes, that is what we see. > SolrMetric

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336891#comment-16336891 ] Erick Erickson commented on SOLR-11882: --- [~ab] kindly provided this suggestion, I applied it - it