[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586762#comment-16586762
]
ASF subversion and git services commented on SOLR-12130:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585796#comment-16585796
]
Shalin Shekhar Mangar commented on SOLR-12130:
--
Thanks Amrit. I'll keep this issue open for
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585680#comment-16585680
]
ASF subversion and git services commented on SOLR-12130:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585679#comment-16585679
]
ASF subversion and git services commented on SOLR-12130:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585525#comment-16585525
]
Amrit Sarkar commented on SOLR-12130:
-
Hi [~shalinmangar], updated patch uploaded, added more
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584271#comment-16584271
]
Amrit Sarkar commented on SOLR-12130:
-
Updated new patch with remaining tests, I need to add proper
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583805#comment-16583805
]
Amrit Sarkar commented on SOLR-12130:
-
Hi Shalin, thanks for reviewing the patch.
bq. Is that
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583233#comment-16583233
]
Shalin Shekhar Mangar commented on SOLR-12130:
--
The latest patch has a BadApple annotation
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582378#comment-16582378
]
Amrit Sarkar commented on SOLR-12130:
-
Uploaded fresh patch, against master. updated
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582358#comment-16582358
]
Amrit Sarkar commented on SOLR-12130:
-
Thanks Shalin. Yes, those methods will be removed from
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582281#comment-16582281
]
Shalin Shekhar Mangar commented on SOLR-12130:
--
Hi Amrit, your patch only adds a new test.
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573206#comment-16573206
]
Amrit Sarkar commented on SOLR-12130:
-
Thanks Shalin, I updated jira as per master. Not able to run
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570392#comment-16570392
]
Shalin Shekhar Mangar commented on SOLR-12130:
--
What's the status on these improvements? Is
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463703#comment-16463703
]
Amrit Sarkar commented on SOLR-12130:
-
Thanks Varun,
I have broken down the testClass in two;
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440371#comment-16440371
]
Varun Thacker commented on SOLR-12130:
--
I spoke to Amrit offline , let's leverage SolrCloudTestCase
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422140#comment-16422140
]
Amrit Sarkar commented on SOLR-12130:
-
Uploaded the same patch with renamed files, test class with
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415504#comment-16415504
]
Amrit Sarkar commented on SOLR-12130:
-
Understood what each test method is doing and isolated test
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407929#comment-16407929
]
Amrit Sarkar commented on SOLR-12130:
-
Tests total time: *30 minutes* approx.
Following is the approx
18 matches
Mail list logo