[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700139#comment-16700139 ] ASF subversion and git services commented on SOLR-12775: Commit

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695923#comment-16695923 ] ASF subversion and git services commented on SOLR-12775: Commit

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-22 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695884#comment-16695884 ] Lucene/Solr QA commented on SOLR-12775: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-21 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694923#comment-16694923 ] Alan Woodward commented on SOLR-12775: -- > Solr should log a warning Ah turns out it does, I was

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-21 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694853#comment-16694853 ] Lucene/Solr QA commented on SOLR-12775: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693283#comment-16693283 ] Uwe Schindler commented on SOLR-12775: -- bq. TokenizerFactory.create() returns a Tokenizer, so we

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693152#comment-16693152 ] Uwe Schindler commented on SOLR-12775: -- bq. Patch with test. I had thought that the use of

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693147#comment-16693147 ] Alan Woodward commented on SOLR-12775: -- TokenizerFactory.create() returns a Tokenizer, so we can't

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693140#comment-16693140 ] Uwe Schindler commented on SOLR-12775: -- Nevertheless, wh not just create a Tokenizer factory that

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693139#comment-16693139 ] Uwe Schindler commented on SOLR-12775: -- A sorry, I forgot that normalize is gone in

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693132#comment-16693132 ] Uwe Schindler commented on SOLR-12775: -- IMHO, we do not need to clone the tokenizer, as the base

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-20 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692982#comment-16692982 ] Lucene/Solr QA commented on SOLR-12775: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-11-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691533#comment-16691533 ] Alan Woodward commented on SOLR-12775: -- Final patch for Yetus to grind on > Add a deprecated

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621827#comment-16621827 ] Alan Woodward commented on SOLR-12775: -- Updated patch, taking into account changes in how

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-19 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620851#comment-16620851 ] David Smiley commented on SOLR-12775: - That's a great user experience; sure.  Please go ahead with

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620573#comment-16620573 ] Alan Woodward commented on SOLR-12775: -- I'd argue that a rolling upgrade should work the other way

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617451#comment-16617451 ] David Smiley commented on SOLR-12775: - A rolling upgrade would be change the schema 1st – use

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616881#comment-16616881 ] Alan Woodward commented on SOLR-12775: -- Breaking schemas over a major version with no deprecation

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616836#comment-16616836 ] David Smiley commented on SOLR-12775: - Why keep this around in Solr?  Can't a Solr user upgrade their

[jira] [Commented] (SOLR-12775) Add a deprecated implementation of LowerCaseTokenizer

2018-09-15 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616455#comment-16616455 ] Alan Woodward commented on SOLR-12775: -- Patch with test.  I had thought that the use of deprecated