[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864072#comment-16864072 ] Munendra S N commented on SOLR-13509: - (y) > NullPointerException in JSON Facet if

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864052#comment-16864052 ] Mikhail Khludnev commented on SOLR-13509: - Hmm, I don't think it deserve pitching into 8.1.2,

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863898#comment-16863898 ] Munendra S N commented on SOLR-13509: - [~mkhludnev] Thanks for merging this. There are plans for

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862249#comment-16862249 ] ASF subversion and git services commented on SOLR-13509: Commit

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862245#comment-16862245 ] ASF subversion and git services commented on SOLR-13509: Commit

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861737#comment-16861737 ] Munendra S N commented on SOLR-13509: - [~mkhludnev] Changes LGTM > NullPointerException in JSON

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861550#comment-16861550 ] Mikhail Khludnev commented on SOLR-13509: - I dropped a few null check for shards response header,

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860705#comment-16860705 ] Lucene/Solr QA commented on SOLR-13509: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859437#comment-16859437 ] Lucene/Solr QA commented on SOLR-13509: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859113#comment-16859113 ] Munendra S N commented on SOLR-13509: - [^SOLR-13509.patch] {quote}I just would disagree with

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859087#comment-16859087 ] Lucene/Solr QA commented on SOLR-13509: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859000#comment-16859000 ] Mikhail Khludnev commented on SOLR-13509: - {quote}For now, adding QTime only when

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858652#comment-16858652 ] Munendra S N commented on SOLR-13509: - [^SOLR-13509.patch] patch with some no-commit * Fixes the

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858102#comment-16858102 ] Mikhail Khludnev commented on SOLR-13509: - I think your points are all correct. I suppose we

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857115#comment-16857115 ] Lucene/Solr QA commented on SOLR-13509: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856345#comment-16856345 ] Munendra S N commented on SOLR-13509: - {quote}Shouldn't FacetModule.handleResponses just bypass if

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855845#comment-16855845 ] Mikhail Khludnev commented on SOLR-13509: - Right, this was introduced by SOLR-9882. I suppose

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854902#comment-16854902 ] Munendra S N commented on SOLR-13509: - [^SOLR-13509.patch] Corrected the test. Here, Always

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854870#comment-16854870 ] Munendra S N commented on SOLR-13509: - [^SOLR-13509.patch] Simple test demonstrating the problem(this

[jira] [Commented] (SOLR-13509) NullPointerException in JSON Facet if omitHeaders=true

[ https://issues.apache.org/jira/browse/SOLR-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854827#comment-16854827 ] Munendra S N commented on SOLR-13509: - I think this is caused by SOLR-9882 > NullPointerException in