[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190631#comment-13190631
]
Uwe Schindler commented on SOLR-3054:
-
Hi Tommaso,
patch look good, a few things:
- I
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190641#comment-13190641
]
Uwe Schindler commented on SOLR-3054:
-
I looked up the other TokenFilters that filter
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190643#comment-13190643
]
Tommaso Teofili commented on SOLR-3054:
---
bq. I looked up the other TokenFilters that
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190691#comment-13190691
]
Robert Muir commented on SOLR-3054:
---
{quote}
in the first patch I went for consistency
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190694#comment-13190694
]
Uwe Schindler commented on SOLR-3054:
-
OK, I think we should commit them with false as
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190717#comment-13190717
]
Robert Muir commented on SOLR-3054:
---
+1
Add a TypeTokenFilterFactory
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190719#comment-13190719
]
Uwe Schindler commented on SOLR-3054:
-
+1, I will commit this later!
[
https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190749#comment-13190749
]
Tommaso Teofili commented on SOLR-3054:
---
Thanks Uwe
Add a