[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610760#comment-13610760
]
Commit Tag Bot commented on SOLR-3879:
--
[branch_4x commit] Michael McCandless
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463146#comment-13463146
]
Michael McCandless commented on SOLR-3879:
--
I'll fix smokeTestRelease to check for
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463155#comment-13463155
]
Mark Miller commented on SOLR-3879:
---
Very nice.
war file has
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463161#comment-13463161
]
Uwe Schindler commented on SOLR-3879:
-
We should maybe also do the same check on all
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463163#comment-13463163
]
Michael McCandless commented on SOLR-3879:
--
Uwe, good idea: I'll do that.
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463188#comment-13463188
]
Robert Muir commented on SOLR-3879:
---
+1 to commit mike's latest patch (the test) and
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463199#comment-13463199
]
Uwe Schindler commented on SOLR-3879:
-
Looks good! My intention was to only check all
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463202#comment-13463202
]
Uwe Schindler commented on SOLR-3879:
-
Oh, we should not add the servlet API lib to the
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463205#comment-13463205
]
Robert Muir commented on SOLR-3879:
---
I thought about this too, it seems useless to me to
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463217#comment-13463217
]
Uwe Schindler commented on SOLR-3879:
-
It is not only useless, its as stupid as
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463235#comment-13463235
]
Uwe Schindler commented on SOLR-3879:
-
Mike: should we open another issue in LUCENE?
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463237#comment-13463237
]
Robert Muir commented on SOLR-3879:
---
just open another issue to not put this jar file in
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462013#comment-13462013
]
Robert Muir commented on SOLR-3879:
---
I don't see a servlet-api.jar in the 3.6.0 war, but
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462021#comment-13462021
]
Uwe Schindler commented on SOLR-3879:
-
It is definitely a bug to include that jar file.
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462022#comment-13462022
]
Yonik Seeley commented on SOLR-3879:
bq. I don't see a servlet-api.jar in the 3.6.0
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462132#comment-13462132
]
Robert Muir commented on SOLR-3879:
---
Roman your patch looks good.
smokeTestRelease.py
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462149#comment-13462149
]
Roman Shaposhnik commented on SOLR-3879:
Thanks! I'll update the patch shortly to
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462161#comment-13462161
]
Mark Miller commented on SOLR-3879:
---
bq. peek inside the war in smokeTestRelease.py and
[
https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462177#comment-13462177
]
Uwe Schindler commented on SOLR-3879:
-
+1 to fix this issue!
war file
19 matches
Mail list logo