[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145963#comment-15145963
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145966#comment-15145966
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144783#comment-15144783
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144818#comment-15144818
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145302#comment-15145302
]
Christine Poerschke commented on SOLR-5730:
---
Changes committed to master and cherry-picked to
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145292#comment-15145292
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145218#comment-15145218
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145569#comment-15145569
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145565#comment-15145565
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142711#comment-15142711
]
Christine Poerschke commented on SOLR-5730:
---
Thanks for the review comments [~shaie]!
bq. ... I
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143595#comment-15143595
]
Christine Poerschke commented on SOLR-5730:
---
Attached revised SOLR-5730-part1and2.patch - new or
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143646#comment-15143646
]
Shai Erera commented on SOLR-5730:
--
Patch looks good! One minor comment -- in
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143094#comment-15143094
]
ASF subversion and git services commented on SOLR-5730:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143200#comment-15143200
]
Christine Poerschke commented on SOLR-5730:
---
bq. SolrIndexSearcher:
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143223#comment-15143223
]
Christine Poerschke commented on SOLR-5730:
---
bq. What's the purpose of
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141942#comment-15141942
]
Christine Poerschke commented on SOLR-5730:
---
{{SOLR-5730-part1and2.patch}} attached against
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142109#comment-15142109
]
Shai Erera commented on SOLR-5730:
--
Few comments about the patch:
* In QueryComponent:
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139818#comment-15139818
]
Christine Poerschke commented on SOLR-5730:
---
Resumed rebasing work for this ticket here,
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130096#comment-15130096
]
Shai Erera commented on SOLR-5730:
--
Hi [~jkrupan], your understanding is correct.
bq. The third ticket
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129131#comment-15129131
]
Jack Krupansky commented on SOLR-5730:
--
Let me try again... again, my apologies for not commenting
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128698#comment-15128698
]
Shai Erera commented on SOLR-5730:
--
[~hossman], this issue is now on hold until we finish with SOLR-8621
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128346#comment-15128346
]
Christine Poerschke commented on SOLR-5730:
---
[~jkrupan] - it's never too late to join the party
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128656#comment-15128656
]
Hoss Man commented on SOLR-5730:
I think the direction being taken in SOLR-8621 looks like a good idea in
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128303#comment-15128303
]
Jack Krupansky commented on SOLR-5730:
--
Sorry for arriving so late to the party here, but I've gotten
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123397#comment-15123397
]
Christine Poerschke commented on SOLR-5730:
---
Help and collaboration always welcome :-) Have
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123394#comment-15123394
]
Christine Poerschke commented on SOLR-5730:
---
SOLR-5730 will be suspended for now, to resume once
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119121#comment-15119121
]
Christine Poerschke commented on SOLR-5730:
---
I like the idea of a {{MergePolicyFactory}} and the
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119125#comment-15119125
]
Shai Erera commented on SOLR-5730:
--
I don't think that we need to change all MPs to MPFs. If you encounter
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119309#comment-15119309
]
Christine Poerschke commented on SOLR-5730:
---
bq. ... did you first intend to introduce MPF ...
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119287#comment-15119287
]
Shai Erera commented on SOLR-5730:
--
OK I see, then in this issue you want to add another "alongside"
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119206#comment-15119206
]
Christine Poerschke commented on SOLR-5730:
---
bq. I don't think that we need to change all MPs to
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119350#comment-15119350
]
Shai Erera commented on SOLR-5730:
--
OK so in that case it's better. We'll put this issue on-hold for MPF,
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117111#comment-15117111
]
Christine Poerschke commented on SOLR-5730:
---
The revised attached patch uses this alternative.
A
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117104#comment-15117104
]
Christine Poerschke commented on SOLR-5730:
---
Have chosen
{code}
+ if (segmentTerminatedEarly
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118799#comment-15118799
]
Shai Erera commented on SOLR-5730:
--
Rethinking my proposal, I'm not sure chaining merge policies is the
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117549#comment-15117549
]
Shai Erera commented on SOLR-5730:
--
I was hoping that we'd change solrconfig.xml to support something like
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117693#comment-15117693
]
Christine Poerschke commented on SOLR-5730:
---
bq. solrconfig.xml to support something like a
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117738#comment-15117738
]
David Smiley commented on SOLR-5730:
+1 to chaining.
As an aside, It's nice to see the collective
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117967#comment-15117967
]
Shai Erera commented on SOLR-5730:
--
I'm OK with chaining, but then can we at least wrap all MPs in a
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113266#comment-15113266
]
Hoss Man commented on SOLR-5730:
bq. Any views on this alternative?
+1
> make Lucene's SortingMergePolicy
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113257#comment-15113257
]
Christine Poerschke commented on SOLR-5730:
---
*Any thoughts on how crucial support for the enable
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110679#comment-15110679
]
Christine Poerschke commented on SOLR-5730:
---
bq. ... i'm not really a fan of the 2 new disjoint
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110696#comment-15110696
]
Christine Poerschke commented on SOLR-5730:
---
bq. I'm wondering if its better to have the
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110684#comment-15110684
]
Christine Poerschke commented on SOLR-5730:
---
bq. If there is an existing value, the new one
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111026#comment-15111026
]
Christine Poerschke commented on SOLR-5730:
---
Okay, if the _"solrconfig.xml references schema.xml
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110884#comment-15110884
]
Tomás Fernández Löbbe commented on SOLR-5730:
-
Missed that.
The parameter makes more sense
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110927#comment-15110927
]
Hoss Man commented on SOLR-5730:
bq. Alternative #1 solrconfig.xml element only:
I think this is the best
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109905#comment-15109905
]
Tomás Fernández Löbbe commented on SOLR-5730:
-
This feature sounds really good. I have some
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109291#comment-15109291
]
Christine Poerschke commented on SOLR-5730:
---
Please find attached a two-part patch against latest
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109442#comment-15109442
]
Hoss Man commented on SOLR-5730:
Probably a naive question, but...
I understand that the reason we need
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002585#comment-15002585
]
Christine Poerschke commented on SOLR-5730:
---
Making the {{SortingMergePolicy}} configurable means
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1460#comment-1460
]
ASF GitHub Bot commented on SOLR-5730:
--
GitHub user cpoerschke opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608899#comment-14608899
]
Christine Poerschke commented on SOLR-5730:
---
Uploaded [incomplete
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923920#comment-13923920
]
Robert Muir commented on SOLR-5730:
---
Hello, some things that might simplify some of the
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911571#comment-13911571
]
Christine Poerschke commented on SOLR-5730:
---
Hi Shawn, yes i'm having a go at
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909443#comment-13909443
]
Shawn Heisey commented on SOLR-5730:
[~cpoerschke], are you in a position to build a
[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901482#comment-13901482
]
ASF GitHub Bot commented on SOLR-5730:
--
GitHub user cpoerschke opened a pull request:
57 matches
Mail list logo