[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881908#comment-16881908
]
jia yang commented on SOLR-5837:
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881849#comment-16881849
]
jia yang commented on SOLR-5837:
hi,the equals methods is not required? I think it useful, not in test
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937991#comment-13937991
]
Mark Miller commented on SOLR-5837:
---
If you look at the previous commits, you will see
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934902#comment-13934902
]
ASF subversion and git services commented on SOLR-5837:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934929#comment-13934929
]
ASF subversion and git services commented on SOLR-5837:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930203#comment-13930203
]
Noble Paul commented on SOLR-5837:
--
The equals and hashCode() will fail only when you are
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930509#comment-13930509
]
Mark Miller commented on SOLR-5837:
---
Exactly - you point out why they should not be used
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930762#comment-13930762
]
Robert Muir commented on SOLR-5837:
---
My recommendation in a case like this: if you want
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930816#comment-13930816
]
Varun Thacker commented on SOLR-5837:
-
So I guess we should revert this then and I will
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931290#comment-13931290
]
Noble Paul commented on SOLR-5837:
--
Yes, remove the equals and hashCode from the
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925625#comment-13925625
]
ASF subversion and git services commented on SOLR-5837:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925631#comment-13925631
]
ASF subversion and git services commented on SOLR-5837:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925884#comment-13925884
]
Mark Miller commented on SOLR-5837:
---
Yonik's comment still needs to be addressed - the
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925887#comment-13925887
]
Mark Miller commented on SOLR-5837:
---
The following also should be addressed:
{noformat}
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925904#comment-13925904
]
ASF subversion and git services commented on SOLR-5837:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925908#comment-13925908
]
ASF subversion and git services commented on SOLR-5837:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925941#comment-13925941
]
Varun Thacker commented on SOLR-5837:
-
[~hakeber] Looks like you cleaned up code from
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924989#comment-13924989
]
Mark Miller commented on SOLR-5837:
---
Thanks Varun! We should add a couple tests for this
[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925033#comment-13925033
]
Yonik Seeley commented on SOLR-5837:
I think it's probably OK to add these methods for
19 matches
Mail list logo
