[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312607#comment-14312607
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312617#comment-14312617
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312635#comment-14312635
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311492#comment-14311492
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311358#comment-14311358
]
Mark Miller commented on SOLR-6640:
---
Thanks shalin - my chaosmonkey jobs went well
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311557#comment-14311557
]
Anshum Gupta commented on SOLR-6640:
I think we use the standard 1024 conversion factor
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311548#comment-14311548
]
Anshum Gupta commented on SOLR-6640:
Thanks for wrapping this one up Mark. Looks good!
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311555#comment-14311555
]
Mark Miller commented on SOLR-6640:
---
bq. 100kb would be copied but the check seems to be
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311600#comment-14311600
]
Mark Miller commented on SOLR-6640:
---
Yeah, I'm not really arguing one way or another - I
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311611#comment-14311611
]
Anshum Gupta commented on SOLR-6640:
With you on that anyways. I think this issue is
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311626#comment-14311626
]
Mark Miller commented on SOLR-6640:
---
Yeah, I think we are prob good. I'll make the
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310846#comment-14310846
]
Mark Miller commented on SOLR-6640:
---
We should not log an error when the compare method
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310855#comment-14310855
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310858#comment-14310858
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310819#comment-14310819
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310837#comment-14310837
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310840#comment-14310840
]
Mark Miller commented on SOLR-6640:
---
Anyone that can help with review of these commits,
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310808#comment-14310808
]
Mark Miller commented on SOLR-6640:
---
Since committing that to trunk, my trunk runs are
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310917#comment-14310917
]
Gregory Chanan commented on SOLR-6640:
--
Did a quick pass, looks good.
One suggestion
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311099#comment-14311099
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311091#comment-14311091
]
Mark Miller commented on SOLR-6640:
---
I've had my local jenkins machine push it's 10 chaos
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311102#comment-14311102
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311134#comment-14311134
]
Shalin Shekhar Mangar commented on SOLR-6640:
-
Thanks Mark. This has helped a
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311034#comment-14311034
]
Mark Miller commented on SOLR-6640:
---
Thanks Greg, I'll incorporate - wasn't very happy
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309772#comment-14309772
]
Varun Thacker commented on SOLR-6640:
-
Sorry this was supposed to go in SOLR-6920. I'll
[
https://issues.apache.org/jira/browse/SOLR-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309982#comment-14309982
]
ASF subversion and git services commented on SOLR-6640:
---
Commit
26 matches
Mail list logo