[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967445#comment-14967445
]
Kevin Risden commented on SOLR-7986:
[~susheel2...@gmail.com] I worked on some of the DriverImpl logic
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968382#comment-14968382
]
Susheel Kumar commented on SOLR-7986:
-
Hi Kevin,
I have created SOLR-8184 for negative tests and i see
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968384#comment-14968384
]
Susheel Kumar commented on SOLR-7986:
-
Hi Joel,
Created SOLR-8184 and attached the patch with tests
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966069#comment-14966069
]
Joel Bernstein commented on SOLR-7986:
--
Hi [~susheel2...@gmail.com], I just noticed your comment on
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903665#comment-14903665
]
Susheel Kumar commented on SOLR-7986:
-
Hi Joel,
I added locally 3 bad connection string tests. Please
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875690#comment-14875690
]
Joel Bernstein commented on SOLR-7986:
--
Thanks [~thetaphi] for your help on this ticket!
> JDBC
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875671#comment-14875671
]
ASF subversion and git services commented on SOLR-7986:
---
Commit 1703867 from
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791671#comment-14791671
]
Uwe Schindler commented on SOLR-7986:
-
Hi Joel,
yes, @SuppressForbidden is the way to go. Choose the
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804674#comment-14804674
]
Joel Bernstein commented on SOLR-7986:
--
Thanks Uwe, I believe I've got the right SuppresForbidden.
>
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804680#comment-14804680
]
Joel Bernstein commented on SOLR-7986:
--
Just wrote a small test client with the JDBC Driver and it
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791433#comment-14791433
]
Joel Bernstein commented on SOLR-7986:
--
[~thetaphi], I ran into a forbidden API's issue in
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791461#comment-14791461
]
Joel Bernstein commented on SOLR-7986:
--
I found the @SuppressForbidden annotation which allowed
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741264#comment-14741264
]
Joel Bernstein commented on SOLR-7986:
--
[~thetaphi]
> JDBC Driver for SQL Interface
>
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741311#comment-14741311
]
Joel Bernstein commented on SOLR-7986:
--
Thanks for the patch Uwe! I'll play around with
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741269#comment-14741269
]
Joel Bernstein commented on SOLR-7986:
--
Uwe, I was reading the spec on the META-INF resource and I'm
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741332#comment-14741332
]
Uwe Schindler commented on SOLR-7986:
-
Most drivers I have seen (e.g. mysql) do both. Inside static
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741377#comment-14741377
]
Joel Bernstein commented on SOLR-7986:
--
Ok, thanks!
> JDBC Driver for SQL Interface
>
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741368#comment-14741368
]
Uwe Schindler commented on SOLR-7986:
-
One thing about your Driver:
According to spec, the driver
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741396#comment-14741396
]
Uwe Schindler commented on SOLR-7986:
-
Looks good. So I assume it works without the Class#forName()
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741418#comment-14741418
]
Joel Bernstein commented on SOLR-7986:
--
Just tested without the META-INF resource and it does work
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741281#comment-14741281
]
Uwe Schindler commented on SOLR-7986:
-
Same as adding codecs to Lucene. Just create META-INF/services
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739192#comment-14739192
]
Uwe Schindler commented on SOLR-7986:
-
See
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739189#comment-14739189
]
Uwe Schindler commented on SOLR-7986:
-
For a full compliant JDBC driver you should also add a META-INF
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739208#comment-14739208
]
Joel Bernstein commented on SOLR-7986:
--
Thanks, I'll take a look!
> JDBC Driver for SQL Interface
>
[
https://issues.apache.org/jira/browse/SOLR-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717899#comment-14717899
]
Joel Bernstein commented on SOLR-7986:
--
Some thoughts on the design:
1) The
25 matches
Mail list logo
