[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809882#comment-15809882 ] Mark Miller commented on SOLR-8292: --- Correct. We know how much we are supposed to read, we don't need a

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806407#comment-15806407 ] Cao Manh Dat commented on SOLR-8292: I think people kinda of misunderstanding this line {code} *

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805015#comment-15805015 ] Erick Erickson commented on SOLR-8292: -- [~caomanhdat317] All I was really looking for was whether, in

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803900#comment-15803900 ] Cao Manh Dat commented on SOLR-8292: Hi Erick, I'm not familiar with CDCR code much. But I will give it

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803488#comment-15803488 ] Erick Erickson commented on SOLR-8292: -- [~caomanhdat] You've also been in the tlog code significantly

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802475#comment-15802475 ] Erick Erickson commented on SOLR-8292: -- [~md...@cloudera.com][~rendel][~markrmil...@gmail.com] I

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037616#comment-15037616 ] Renaud Delbru commented on SOLR-8292: - Perhaps related to SOLR-4116 ? > TransactionLog.next() does not

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010699#comment-15010699 ] Renaud Delbru commented on SOLR-8292: - I have checked on the cdcr code side, and whenever a log reader

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006519#comment-15006519 ] Renaud Delbru commented on SOLR-8292: - I have reviewed all the methods writing records to the tlog

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006537#comment-15006537 ] Renaud Delbru commented on SOLR-8292: - The convention over the log reader is that it should not be used

[jira] [Commented] (SOLR-8292) TransactionLog.next() does not honor contract and return null for EOF

[ https://issues.apache.org/jira/browse/SOLR-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005479#comment-15005479 ] Erick Erickson commented on SOLR-8292: -- Bah! fis is a FastInputStream, not FileInputStream. I'll try