[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022633#comment-15022633
]
Mike Drob commented on SOLR-8324:
-
I hadn't had a chance to start on the MethodHandles patch, feel free to
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022237#comment-15022237
]
Mike Drob commented on SOLR-8324:
-
I'll work on putting together a patch that uses the MethodHandles
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022487#comment-15022487
]
Jason Gerlowski commented on SOLR-8324:
---
Hey Mike, just an FYI- I've got a patch almost finished that
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022488#comment-15022488
]
Jason Gerlowski commented on SOLR-8324:
---
Hey Mike, just an FYI- I've got a patch almost finished that
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022234#comment-15022234
]
Mike Drob commented on SOLR-8324:
-
Ah, missed the lookupClass. Thanks for corroborating this.
> Logger
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020323#comment-15020323
]
Uwe Schindler commented on SOLR-8324:
-
bq. I did try and use MethodHandles when Mike mentioned it, but
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018480#comment-15018480
]
Shawn Heisey commented on SOLR-8324:
Regarding task #2, making loggers private is one aspect of not
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018492#comment-15018492
]
Mike Drob commented on SOLR-8324:
-
I believe that in Java 8 you can do something like...
{noformat}
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018530#comment-15018530
]
Shawn Heisey commented on SOLR-8324:
I found something that seems to work, and I think will work in
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018567#comment-15018567
]
Shawn Heisey commented on SOLR-8324:
Yes, copy/paste errors are a possible source of problems with
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018547#comment-15018547
]
Shawn Heisey commented on SOLR-8324:
A static method could be added to a utility class, using the
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018543#comment-15018543
]
Mike Drob commented on SOLR-8324:
-
What specifically are we trying to solve by doing it that way? Prevent
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018677#comment-15018677
]
Mike Drob commented on SOLR-8324:
-
Using a utility method still wouldn't enforce that the Logger is
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018913#comment-15018913
]
Shawn Heisey commented on SOLR-8324:
If there is a legitimate reason to share loggers, then there's no
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019092#comment-15019092
]
Mark Miller commented on SOLR-8324:
---
Much simpler to just give each class it's own logger. I don't think
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019131#comment-15019131
]
Uwe Schindler commented on SOLR-8324:
-
I would not do this. Creating a stack trace for every class is
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019140#comment-15019140
]
Uwe Schindler commented on SOLR-8324:
-
bq. Much simpler to just give each class it's own logger. I
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019143#comment-15019143
]
Uwe Schindler commented on SOLR-8324:
-
FYI: Forbiddenapis cannot check for static/nonstatic logging
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019014#comment-15019014
]
Mark Miller commented on SOLR-8324:
---
Personally, I would not worry about a legit reason for sharing
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019070#comment-15019070
]
Yonik Seeley commented on SOLR-8324:
I guess it depends on how one views loggers.
Classes can be
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019086#comment-15019086
]
Shawn Heisey commented on SOLR-8324:
That [1] will probably need to be changed to [2] if the code is
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019122#comment-15019122
]
Uwe Schindler commented on SOLR-8324:
-
You can do this since Java 7, I now use this anywhere. The code
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15019136#comment-15019136
]
Uwe Schindler commented on SOLR-8324:
-
Works also in Java 7. And its fast like hell. Stack traces are
[
https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020305#comment-15020305
]
Shawn Heisey commented on SOLR-8324:
Thanks, Uwe!
I did try and use MethodHandles when Mike mentioned
24 matches
Mail list logo
