[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375958#comment-16375958
]
ASF subversion and git services commented on SOLR-8327:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375957#comment-16375957
]
ASF subversion and git services commented on SOLR-8327:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368682#comment-16368682
]
Noble Paul commented on SOLR-8327:
--
LGTM
> SolrDispatchFilter is not caching new state format, which
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368669#comment-16368669
]
John Gallagher commented on SOLR-8327:
--
[~ichattopadhyaya] that update looks good to me!
>
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362235#comment-16362235
]
Ishan Chattopadhyaya commented on SOLR-8327:
Updated John's patch to use a lookup for version
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360329#comment-16360329
]
Noble Paul commented on SOLR-8327:
--
Yes, use the {{zkClient.exists()}}call which gives a {{ Stat}}
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342326#comment-16342326
]
John Gallagher commented on SOLR-8327:
--
What call are you proposing? `exists` ?
> SolrDispatchFilter
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342325#comment-16342325
]
Noble Paul commented on SOLR-8327:
--
Most of the times the state is downloaded unnecessarily because it is
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341284#comment-16341284
]
Ishan Chattopadhyaya commented on SOLR-8327:
bq. The following code snippet would fetch the
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336092#comment-16336092
]
John Gallagher commented on SOLR-8327:
--
[~noble.paul] I'm happy to try to make that change, if you can
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328289#comment-16328289
]
Noble Paul commented on SOLR-8327:
--
[~varunthacker] We really can't let every node listen to, get notified
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328071#comment-16328071
]
Varun Thacker commented on SOLR-8327:
-
So after this patch we will make one request every 2 seconds to
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327615#comment-16327615
]
Ishan Chattopadhyaya commented on SOLR-8327:
I plan to commit this shortly, unless there are
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299071#comment-16299071
]
ASF GitHub Bot commented on SOLR-8327:
--
Github user slackhappy commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297686#comment-16297686
]
ASF GitHub Bot commented on SOLR-8327:
--
Github user slackhappy commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297495#comment-16297495
]
ASF GitHub Bot commented on SOLR-8327:
--
Github user chatman commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297445#comment-16297445
]
Ishan Chattopadhyaya commented on SOLR-8327:
bq. This approach seems fine to me.
My only
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297410#comment-16297410
]
ASF GitHub Bot commented on SOLR-8327:
--
Github user elyograg commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297372#comment-16297372
]
ASF GitHub Bot commented on SOLR-8327:
--
Github user dragonsinth commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297371#comment-16297371
]
Scott Blum commented on SOLR-8327:
--
https://github.com/apache/lucene-solr/pull/294
> SolrDispatchFilter
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297255#comment-16297255
]
Ishan Chattopadhyaya commented on SOLR-8327:
I tested this today (dockerized Solr + TCPDump on
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672990#comment-15672990
]
Shalin Shekhar Mangar commented on SOLR-8327:
-
No, this is still very relevant. SOLR-9014 was
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672391#comment-15672391
]
Erick Erickson commented on SOLR-8327:
--
[~shalinmangar] Does SOLR-9014 being fixed mean we can close
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250384#comment-15250384
]
Shalin Shekhar Mangar commented on SOLR-8327:
-
Varun, I am auditing all usages of ClusterState
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250374#comment-15250374
]
Varun Thacker commented on SOLR-8327:
-
Also the DistributedUpdateProcessor makes many calls to
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207116#comment-15207116
]
Noble Paul commented on SOLR-8327:
--
you are right. It is not in the scope of {{ZkStateReader}}
>
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207115#comment-15207115
]
Noble Paul commented on SOLR-8327:
--
Smart caching work flow is as follows
# a request for a collection
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207112#comment-15207112
]
Scott Blum commented on SOLR-8327:
--
Thanks for the extra context. So it looks like this falls outside the
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207085#comment-15207085
]
Noble Paul commented on SOLR-8327:
--
[~dragonsinth] Please refer to SOLR-5474 & SOLR-7130
>
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207083#comment-15207083
]
Varun Thacker commented on SOLR-8327:
-
Hi Scott,
This is what I understand what CloudSolrClient does
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207072#comment-15207072
]
Scott Blum commented on SOLR-8327:
--
What does solrj do? How do you know when the cached data is stale?
>
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207038#comment-15207038
]
Noble Paul commented on SOLR-8327:
--
I don't think adding a watch for lazy collection ref is a good idea.
[
https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207019#comment-15207019
]
Scott Blum commented on SOLR-8327:
--
There's a TODO in LazyCollectionRef:
// TODO: consider limited
33 matches
Mail list logo