[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101848#comment-15101848 ] ASF subversion and git services commented on SOLR-8330: --- Commit 1724826 from

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101850#comment-15101850 ] ASF subversion and git services commented on SOLR-8330: --- Commit 1724827 from

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049736#comment-15049736 ] Mike Drob commented on SOLR-8330: - This issue looks done - can we resolve it if there is no further work to

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037606#comment-15037606 ] Ishan Chattopadhyaya commented on SOLR-8330: The MethodHandles.lookup() creates an extra object

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037614#comment-15037614 ] Uwe Schindler commented on SOLR-8330: - The loggers are static, so created once. > Restrict logger

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037625#comment-15037625 ] Ishan Chattopadhyaya commented on SOLR-8330: Ah, I was missing the static part; indeed no

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037649#comment-15037649 ] Uwe Schindler commented on SOLR-8330: - bq. Good to learn about the escape analysis; thanks! This is

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035526#comment-15035526 ] Uwe Schindler commented on SOLR-8330: - +1 Thanks! > Restrict logger visibility throughout the codebase

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035524#comment-15035524 ] ASF subversion and git services commented on SOLR-8330: --- Commit 1717590 from

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037218#comment-15037218 ] ASF subversion and git services commented on SOLR-8330: --- Commit 1717707 from

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037236#comment-15037236 ] Anshum Gupta commented on SOLR-8330: It's now in 5.4. > Restrict logger visibility throughout the

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035630#comment-15035630 ] ASF subversion and git services commented on SOLR-8330: --- Commit 1717604 from

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035654#comment-15035654 ] Anshum Gupta commented on SOLR-8330: I've committed it to both trunk and 5x. I think we should also

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035726#comment-15035726 ] Jason Gerlowski commented on SOLR-8330: --- Thank you Anshum! I think it'd be nice to squeeze into 5.4.

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033319#comment-15033319 ] Uwe Schindler commented on SOLR-8330: - The attached patch no longer applies cleanly. You have to "svn

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033892#comment-15033892 ] Jason Gerlowski commented on SOLR-8330: --- Tests passed for me, so I _think_ this patch should be

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032731#comment-15032731 ] Gregory Chanan commented on SOLR-8330: -- RequestLoggingTest is still relevant -- it checks the output

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032760#comment-15032760 ] Gregory Chanan commented on SOLR-8330: -- BTW changing the requestLog in SolrCore.java to: {code}

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032798#comment-15032798 ] Anshum Gupta commented on SOLR-8330: Thanks Greg and Jason. I'll take a look at this patch and commit

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033273#comment-15033273 ] Uwe Schindler commented on SOLR-8330: - This is the correct fix. Class#toString() (which is used

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033277#comment-15033277 ] Uwe Schindler commented on SOLR-8330: - I will try the patch later, but looks fine to me; small issues:

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030688#comment-15030688 ] Jason Gerlowski commented on SOLR-8330: --- Upon slightly closer inspection, the two interfaces that

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030780#comment-15030780 ] Anshum Gupta commented on SOLR-8330: Sure, sounds good to me. It's reasonable and also helps us move

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030773#comment-15030773 ] Mark Miller commented on SOLR-8330: --- Indeed. We dont need to burn bridges that are not built yet. When we

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030778#comment-15030778 ] Jason Gerlowski commented on SOLR-8330: --- Cool, If Anshum's fine w/ that plan, I'm happy to update the

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030157#comment-15030157 ] Erick Erickson commented on SOLR-8330: -- Just alerting you to this if you run into it. > Restrict

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030055#comment-15030055 ] Anshum Gupta commented on SOLR-8330: If you mean the svn merge, hopefully it'll take care of it. :) >

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030101#comment-15030101 ] Uwe Schindler commented on SOLR-8330: - Hi, I had an idea a minute ago how to prevent incorrectly

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030074#comment-15030074 ] Anshum Gupta commented on SOLR-8330: OpenCloseCoreStressTest is another file with multiple classes.

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030088#comment-15030088 ] Uwe Schindler commented on SOLR-8330: - +1 LGTM > Restrict logger visibility throughout the codebase to

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030093#comment-15030093 ] Jason Gerlowski commented on SOLR-8330: --- Looks good to me; thanks Anshum. > Restrict logger

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030197#comment-15030197 ] Jason Gerlowski commented on SOLR-8330: --- I think having a source-patterns check is a good idea in

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030073#comment-15030073 ] Anshum Gupta commented on SOLR-8330: I couldn't think of an easy way to split it out other than not

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030323#comment-15030323 ] Mark Miller commented on SOLR-8330: --- +1 to Uwe's validator and making the changes for it to pass.

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030215#comment-15030215 ] Anshum Gupta commented on SOLR-8330: [~gerlowskija] About loggers in interfaces, with Java8, you could

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030351#comment-15030351 ] Anshum Gupta commented on SOLR-8330: +1 to Uwe's validator and making those changes but here's my

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030208#comment-15030208 ] Anshum Gupta commented on SOLR-8330: Thanks Uwe! The only thing that's stopping me is, I have a _trans

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030236#comment-15030236 ] Uwe Schindler commented on SOLR-8330: - Hi for the other changes: All fixes are quite easy: 1) maybe we

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030233#comment-15030233 ] Jason Gerlowski commented on SOLR-8330: --- Makes sense, glad I didn't delete them then. That makes it a

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029443#comment-15029443 ] Erick Erickson commented on SOLR-8330: -- CdcrTransactionLog is not in the 5x code line, so that'll be

[jira] [Commented] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it

[ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029441#comment-15029441 ] Mike Drob commented on SOLR-8330: - Yea, I was concerned that there would be some difficulty extracting