[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170884#comment-16170884 ] Cao Manh Dat commented on SOLR-8344: bq. I think I see an existing bug (not introduced here) in the

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170876#comment-16170876 ] ASF subversion and git services commented on SOLR-8344: --- Commit

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170873#comment-16170873 ] ASF subversion and git services commented on SOLR-8344: --- Commit

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169554#comment-16169554 ] Cao Manh Dat commented on SOLR-8344: Thanks for your review, that's great. bq. minor: It's debatable

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165102#comment-16165102 ] David Smiley commented on SOLR-8344: * SolrDocumentFetcher: minor: {{allStoreds}} variables & getter

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162448#comment-16162448 ] Cao Manh Dat commented on SOLR-8344: bq. IIRC, they are both stored and docValues=true currently, which

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158653#comment-16158653 ] Uwe Schindler commented on SOLR-8344: - For the Id field we figured out that it breaks some stuff if

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158607#comment-16158607 ] Yonik Seeley commented on SOLR-8344: A related thing worth thinking about: what should the default be

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158593#comment-16158593 ] David Smiley commented on SOLR-8344: [~thetaphi] it isn't necessary to have a special condition for

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158575#comment-16158575 ] Uwe Schindler commented on SOLR-8344: - I'd always use docValues for the ID field (if available) for the

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158560#comment-16158560 ] David Smiley commented on SOLR-8344: Please post a new patch so we can see before you commit it.

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158102#comment-16158102 ] Cao Manh Dat commented on SOLR-8344: [~tomasflobbe] Yeah in my benchmark for Lucene, they will almost

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158098#comment-16158098 ] Tomás Fernández Löbbe commented on SOLR-8344: - bq. Because we already have to pay for seek cost

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158097#comment-16158097 ] Cao Manh Dat commented on SOLR-8344: BTW I think that for this ticket, the current optimization is good

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158083#comment-16158083 ] Cao Manh Dat commented on SOLR-8344: Ah yeah, you're right. > Decide default when requested fields are

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158082#comment-16158082 ] David Smiley commented on SOLR-8344: I mean just call {{doc.remove(fieldName)}; no need to guard this

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158073#comment-16158073 ] Cao Manh Dat commented on SOLR-8344: bq. Which scenario is this in your benchmark above? Or some other

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158059#comment-16158059 ] David Smiley commented on SOLR-8344: bq. No, It matter in case of "fl" contains a field which is stored

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157864#comment-16157864 ] Cao Manh Dat commented on SOLR-8344: [~dsmiley] bq.I don't think the number of documents is that

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157156#comment-16157156 ] Yonik Seeley commented on SOLR-8344: bq. Why not have the strategy simply observe if it's possible at

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157141#comment-16157141 ] David Smiley commented on SOLR-8344: I don't think the number of documents is that pertinent since both

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156597#comment-16156597 ] Cao Manh Dat commented on SOLR-8344: [~tomasflobbe] I changed start param. Therefore, in the first

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156497#comment-16156497 ] Tomás Fernández Löbbe commented on SOLR-8344: - Interesting! Two questions: bq.

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150447#comment-16150447 ] Cao Manh Dat commented on SOLR-8344: I think instead of find out the default solution. Why don't we do

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036947#comment-16036947 ] David Smiley commented on SOLR-8344: This issue (SOLR-8344) seems to be about a decision, not about

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385318#comment-15385318 ] David Smiley commented on SOLR-8344: bq. Is it possible to preferentially return DV when doing the

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385236#comment-15385236 ] Erick Erickson commented on SOLR-8344: -- Is it possible to preferentially return DV when doing the

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206354#comment-15206354 ] Yonik Seeley commented on SOLR-8344: Related: in my testing, it seemed like retrieving docvalue fields

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205815#comment-15205815 ] Ishan Chattopadhyaya commented on SOLR-8344: Erick, I'll take a fresh look at this post 6.0

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205703#comment-15205703 ] Erick Erickson commented on SOLR-8344: -- What is the status of this now that SOLR-8220 has been

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034083#comment-15034083 ] Yonik Seeley commented on SOLR-8344: Followup of

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034076#comment-15034076 ] Erick Erickson commented on SOLR-8344: -- Moving my comment from SOLR-8220 here, didn't see this ticket

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034126#comment-15034126 ] Erick Erickson commented on SOLR-8344: -- Yeah, removed that all from 8220, thought about it more and

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034206#comment-15034206 ] Ishan Chattopadhyaya commented on SOLR-8344: [~erickerickson] As of now, users got the stored

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034256#comment-15034256 ] Yonik Seeley commented on SOLR-8344: bq. We do want to keep in mind though that from a user

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034370#comment-15034370 ] Erick Erickson commented on SOLR-8344: -- Damn, ya' learn something new every day. It's still a

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034324#comment-15034324 ] Erick Erickson commented on SOLR-8344: -- [~ichattopadhyaya] I think it'd solve the use-case. and I'm +1

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034467#comment-15034467 ] Yonik Seeley commented on SOLR-8344: bq. I'm also concerned with the upgrade case though. If someone

[jira] [Commented] (SOLR-8344) Decide default when requested fields are both column and row stored.

[ https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033823#comment-15033823 ] Yonik Seeley commented on SOLR-8344: Also highly related is what our schema defaults should be. For