[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770669#comment-15770669 ] ASF subversion and git services commented on SOLR-8677: --- Commit 7415d

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770671#comment-15770671 ] ASF subversion and git services commented on SOLR-8677: --- Commit 297b1

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770670#comment-15770670 ] ASF subversion and git services commented on SOLR-8677: --- Commit 69a8a

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745232#comment-15745232 ] Erick Erickson commented on SOLR-8677: -- [~anshumg] I ran across this, can we close it

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259576#comment-15259576 ] Anshum Gupta commented on SOLR-8677: This shouldn't have gone to 5x. My bad! I'll rever

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188241#comment-15188241 ] Anshum Gupta commented on SOLR-8677: Done > SOLR allows creation of shards with invali

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188193#comment-15188193 ] Erick Erickson commented on SOLR-8677: -- [~anshumg] Can this be closed out? > SOLR all

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153872#comment-15153872 ] ASF subversion and git services commented on SOLR-8677: --- Commit 55162

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153873#comment-15153873 ] ASF subversion and git services commented on SOLR-8677: --- Commit 9b9a6

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153871#comment-15153871 ] ASF subversion and git services commented on SOLR-8677: --- Commit 96c01

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153874#comment-15153874 ] ASF subversion and git services commented on SOLR-8677: --- Commit e8acc

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153596#comment-15153596 ] ASF subversion and git services commented on SOLR-8677: --- Commit eb0e2

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153545#comment-15153545 ] ASF subversion and git services commented on SOLR-8677: --- Commit c7c5b

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153402#comment-15153402 ] ASF subversion and git services commented on SOLR-8677: --- Commit a54e8

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153325#comment-15153325 ] ASF subversion and git services commented on SOLR-8677: --- Commit d0123

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149540#comment-15149540 ] Jason Gerlowski commented on SOLR-8677: --- Good changes. I'd thought about having Solr

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149451#comment-15149451 ] Anshum Gupta commented on SOLR-8677: bq. This obviously means some duplicated code, sin

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146701#comment-15146701 ] Jason Gerlowski commented on SOLR-8677: --- I'll just roll it into this patch. Just wan

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146678#comment-15146678 ] Shai Erera commented on SOLR-8677: -- I don't mind either way Jason. Either you add it to th

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146604#comment-15146604 ] Jason Gerlowski commented on SOLR-8677: --- Thanks for the review Shai. Do you want to

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146459#comment-15146459 ] Shai Erera commented on SOLR-8677: -- Also, would u mind adding a CHANGES.txt entry too? >

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146458#comment-15146458 ] Shai Erera commented on SOLR-8677: -- Looks good to me. [~gerlowskija] I know it's not stric

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144989#comment-15144989 ] Jason Gerlowski commented on SOLR-8677: --- This check would need to be put in at least