[jira] [Commented] (SOLR-9878) Code smell in if statement

2016-12-20 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766287#comment-15766287 ] Mikhail Khludnev commented on SOLR-9878: when a fieldType doesn't have RWFF it's cached as null

[jira] [Commented] (SOLR-9878) Code smell in if statement

2016-12-20 Thread Jaechang Nam (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765487#comment-15765487 ] Jaechang Nam commented on SOLR-9878: I'm wondering why the second condition, "||

[jira] [Commented] (SOLR-9878) Code smell in if statement

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765346#comment-15765346 ] ASF subversion and git services commented on SOLR-9878: --- Commit

[jira] [Commented] (SOLR-9878) Code smell in if statement

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765293#comment-15765293 ] ASF subversion and git services commented on SOLR-9878: --- Commit

[jira] [Commented] (SOLR-9878) Code smell in if statement

2016-12-19 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762753#comment-15762753 ] Tomás Fernández Löbbe commented on SOLR-9878: - Yes, that doesn't look right. Also,