Robert Muir created LUCENE-4443: ----------------------------------- Summary: BlockPostingsFormat writes unnecessary skipdata Key: LUCENE-4443 URL: https://issues.apache.org/jira/browse/LUCENE-4443 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.0 Reporter: Robert Muir Fix For: 4.1 Attachments: LUCENE-4443.patch
Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly is 0: see BlockPostingsWriter.startDoc. (Unless I'm missing something, all tests pass with "Block" if i remove it) Separately we should really think about lastPayloadByteUpto, is this worth it? instead when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we are going to decode that block anyway? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org